Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: content/browser/geolocation/network_location_provider_unittest.cc

Issue 10107017: Remove requesting_frame parameters from Geolocation stack (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Comment addressed. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/geolocation/network_location_provider_unittest.cc
diff --git a/content/browser/geolocation/network_location_provider_unittest.cc b/content/browser/geolocation/network_location_provider_unittest.cc
index ae75a73a8f6b00c9cf5f9fb838eca04b79cfb7e1..a98b747d55e2a122304a835c72144d36fd7c961a 100644
--- a/content/browser/geolocation/network_location_provider_unittest.cc
+++ b/content/browser/geolocation/network_location_provider_unittest.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -21,8 +21,6 @@ namespace {
// Constants used in multiple tests.
const char kTestServerUrl[] = "https://www.geolocation.test/service";
-const char kTestHost[] = "myclienthost.test";
-const char kTestHostUrl[] = "http://myclienthost.test/some/path";
const char kTestJson[] = "?browser=chromium&sensor=true";
const char kTestBrowser[] = "browser=chromium";
const char kTestSensor[] = "sensor=true";
@@ -141,7 +139,7 @@ class GeolocationNetworkProviderTest : public testing::Test {
test_server_url_,
access_token_store_->access_token_set_[test_server_url_]);
if (set_permission_granted)
- provider->OnPermissionGranted(GURL(kTestHostUrl));
+ provider->OnPermissionGranted();
return provider;
}
@@ -497,7 +495,7 @@ TEST_F(GeolocationNetworkProviderTest, NetworkRequestDeferredForPermission) {
EXPECT_TRUE(provider->StartProvider(false));
TestURLFetcher* fetcher = get_url_fetcher_and_advance_id();
EXPECT_FALSE(fetcher);
- provider->OnPermissionGranted(GURL(kTestHostUrl));
+ provider->OnPermissionGranted();
fetcher = get_url_fetcher_and_advance_id();
ASSERT_TRUE(fetcher != NULL);
@@ -522,7 +520,7 @@ TEST_F(GeolocationNetworkProviderTest,
fetcher = get_url_fetcher_and_advance_id();
EXPECT_FALSE(fetcher);
- provider->OnPermissionGranted(GURL(kTestHostUrl));
+ provider->OnPermissionGranted();
fetcher = get_url_fetcher_and_advance_id();
ASSERT_TRUE(fetcher != NULL);
« no previous file with comments | « content/browser/geolocation/network_location_provider.cc ('k') | content/browser/geolocation/network_location_request.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698