Migrate WebKit "global script" font prefs.

webkit/glue/webpreferences.cc

Index: webkit/glue/webpreferences.cc
diff --git a/webkit/glue/webpreferences.cc b/webkit/glue/webpreferences.cc
index 359e0b0c7fa2935e535a9e9a283e7e4b2373ada8..0379a5c462da0bc2130f4e93c5d0daaafe143c36 100644
--- a/webkit/glue/webpreferences.cc
+++ b/webkit/glue/webpreferences.cc
@@ -5,6 +5,7 @@
 #include "webkit/glue/webpreferences.h"
 
 #include <unicode/uchar.h>
+#include <unicode/uscript.h>

[viettrungluu, 2012/05/16 13:27:58]

As I said elsewhere, these are really ICU includes -- is it really our practice
to use include them as if they're system headers (the preexisting inclusion of
uchar.h notwithstanding)?

[falken, 2012/05/17 07:08:41]

I've changed the existing include to "unicode/uchar.h".
It seems most files that include ICU do it that way. I found only one file that
uses a path like "third_party/icu/public/common/unicode/uchar.h" for ICU
(system_settings_provider2.h). I'm not sure whether that's a deliberate
preference, though.

 
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
@@ -25,16 +26,14 @@ using WebKit::WebString;
 using WebKit::WebURL;
 using WebKit::WebView;
 
+namespace {
+const char* kCommonScript = uscript_getShortName(USCRIPT_COMMON);

[viettrungluu, 2012/05/16 13:27:58]

Not wanting static initializers applies to all of Chromium, not just ppapi.

Maybe there should be a common constant somewhere for this? (Maybe a |const
static| member of |WebPreferences| called |kCommonScriptName| or some such?)

[falken, 2012/05/17 07:08:41]

I've moved it back to the "Zyyy" constant. I think we wanted to get it from ICU
for readability, but I think just a comment explaining what it is is sufficient.
I agree it'd be good to have that, but can't get ppapi to access it. It compiles
but then a linker error occurs:

out/Release/../../third_party/gold/gold64:
out/Release/obj.target/ppapi/libppapi_shared.a(out/Release/obj.target/ppapi/../ppapi_shared/ppapi/shared_impl/private/ppb_browser_font_trusted_shared.o):
in function ppapi::(anonymous
namespace)::PPFontDescToWebFontDesc(PP_BrowserFont_Trusted_Description const&,
ppapi::Preferences
const&):ppb_browser_font_trusted_shared.cc(.text._ZN5ppapi12_GLOBAL__N_123PPFontDescToWebFontDescERK34PP_BrowserFont_Trusted_DescriptionRKNS_11PreferencesE+0x42b):
error: undefined reference to 'webkit_glue::WebPreferences::kCommonScript'

Maybe it has something to do with DEPS or the WEBKIT_GLUE_EXPORT macro? It
occurs even for a extern const char[] outside of the struct and for a static
member function.

+}
+
 namespace webkit_glue {
 
 WebPreferences::WebPreferences()
-    : standard_font_family(ASCIIToUTF16("Times New Roman")),
-      fixed_font_family(ASCIIToUTF16("Courier New")),
-      serif_font_family(ASCIIToUTF16("Times New Roman")),
-      sans_serif_font_family(ASCIIToUTF16("Arial")),
-      cursive_font_family(ASCIIToUTF16("Script")),
-      fantasy_font_family(),  // Not sure what to use on Windows.
-      default_font_size(16),
+    : default_font_size(16),
       default_fixed_font_size(13),
       minimum_font_size(0),
       minimum_logical_font_size(6),
@@ -107,6 +106,18 @@ WebPreferences::WebPreferences()
       per_tile_painting_enabled(false),
       css_regions_enabled(false),
       css_shaders_enabled(false) {
+  standard_font_family_map[kCommonScript] =
+      ASCIIToUTF16("Times New Roman");
+  fixed_font_family_map[kCommonScript] =
+      ASCIIToUTF16("Courier New");
+  serif_font_family_map[kCommonScript] =
+      ASCIIToUTF16("Times New Roman");
+  sans_serif_font_family_map[kCommonScript] =
+      ASCIIToUTF16("Arial");
+  cursive_font_family_map[kCommonScript] =
+      ASCIIToUTF16("Script");
+  fantasy_font_family_map[kCommonScript] =
+      ASCIIToUTF16("Impact");
 }
 
 WebPreferences::~WebPreferences() {
@@ -168,12 +179,6 @@ void ApplyFontsFromMap(const WebPreferences::ScriptFontFamilyMap& map,
 
 void WebPreferences::Apply(WebView* web_view) const {
   WebSettings* settings = web_view->settings();
-  settings->setStandardFontFamily(standard_font_family);
-  settings->setFixedFontFamily(fixed_font_family);
-  settings->setSerifFontFamily(serif_font_family);
-  settings->setSansSerifFontFamily(sans_serif_font_family);
-  settings->setCursiveFontFamily(cursive_font_family);
-  settings->setFantasyFontFamily(fantasy_font_family);
   ApplyFontsFromMap(standard_font_family_map, setStandardFontFamilyWrapper,
                     settings);
   ApplyFontsFromMap(fixed_font_family_map, setFixedFontFamilyWrapper, settings);