chrome/common/extensions/api/experimental.fontSettings.json - Issue 10107014: Migrate WebKit "global script" font prefs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/experimental.fontSettings.json

Issue 10107014: Migrate WebKit "global script" font prefs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review comments Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/prefs/prefs_tab_helper_browsertest.cc ('K') | « chrome/browser/ui/webui/options2/font_settings_utils2_mac.mm ('k') | chrome/common/extensions/docs/experimental.fontSettings.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/experimental.fontSettings.json

diff --git a/chrome/common/extensions/api/experimental.fontSettings.json b/chrome/common/extensions/api/experimental.fontSettings.json

index de7e6c527f2eef0d28975cb80319c58651f31f77..c56cec3bac54a3cc4beafd08d0360aaa6488d791 100644

--- a/chrome/common/extensions/api/experimental.fontSettings.json

+++ b/chrome/common/extensions/api/experimental.fontSettings.json

@@ -27,9 +27,9 @@

"enum": [ "Arab", "Armn", "Beng", "Cans", "Cher", "Cyrl", "Deva", "Ethi", "Geor",

"Grek", "Gujr", "Guru", "Hang", "Hans", "Hant", "Hebr", "Hrkt", "Knda",

"Khmr", "Laoo", "Mlym", "Mong", "Mymr", "Orya", "Sinh", "Taml", "Telu",

- "Thaa", "Thai", "Tibt", "Yiii"

+ "Thaa", "Thai", "Tibt", "Yiii", "Zyyy"

- "description": "An ISO 15924 script code."

+ "description": "An ISO 15924 script code. The default, or global, script is represented by script code \"Zyyy\"."

{

"id": "GenericFamily",

@@ -82,7 +82,7 @@

"properties": {

"script": {

"$ref": "ScriptCode",

- "description": "The script for which the font should be retrieved. If omitted, the font for the global script is retrieved.",

+ "description": "The script for which the font should be retrieved. If omitted, the font setting for the global script (script code \"Zyyy\") is retrieved.",

"optional": true

"genericFamily": {

@@ -120,7 +120,7 @@

"properties": {

"script": {

"$ref": "ScriptCode",

- "description": "The script code which the font should be set. If omitted, the font for the global script is set.",

+ "description": "The script code which the font should be set. If omitted, the font setting for the global script (script code \"Zyyy\") is set.",

"optional": true

"genericFamily": {

@@ -455,7 +455,7 @@

"fontName": { "type": "string" },

"script": {

"$ref": "ScriptCode",

- "description": "The script code for which the font setting has changed. If omitted, the global script font setting has changed.",

+ "description": "The script code for which the font setting has changed.",

"optional": true

"genericFamily": {