Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: ppapi/shared_impl/private/ppb_font_shared.cc

Issue 10107014: Migrate WebKit "global script" font prefs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review comments Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/shared_impl/private/ppb_font_shared.cc
diff --git a/ppapi/shared_impl/private/ppb_font_shared.cc b/ppapi/shared_impl/private/ppb_font_shared.cc
index 391808862fe7581ff9b1d48f6e2cc2bdbe06657f..ba60dc2d435726eabc3ba80e25b4ded167b670d7 100644
--- a/ppapi/shared_impl/private/ppb_font_shared.cc
+++ b/ppapi/shared_impl/private/ppb_font_shared.cc
@@ -4,6 +4,8 @@
#include "ppapi/shared_impl/private/ppb_font_shared.h"
+#include <unicode/uscript.h>
+
#include "base/debug/trace_event.h"
#include "base/string_util.h"
#include "base/utf_string_conversions.h"
@@ -40,6 +42,16 @@ namespace ppapi {
namespace {
+const char *kCommonScript = uscript_getShortName(USCRIPT_COMMON);
tony 2012/05/09 17:11:15 Nit: char*
falken 2012/05/11 11:04:14 Done.
+
+string16 GetFontFromMap(const WebPreferences::ScriptFontFamilyMap& map,
+ const std::string& script) {
+ WebPreferences::ScriptFontFamilyMap::const_iterator it = map.find(script);
+ if (it != map.end())
+ return it->second;
+ return string16();
+}
+
// Converts the given PP_TextRun to a TextRun, returning true on success.
// False means the input was invalid.
bool PPTextRunToTextRun(const PP_TextRun_Dev* run,
@@ -92,17 +104,21 @@ WebFontDescription PPFontDescToWebFontDesc(const PP_FontDescription_Dev& font,
// Resolve the generic family.
switch (font.family) {
case PP_FONTFAMILY_SERIF:
- resolved_family = prefs.serif_font_family;
+ resolved_family = GetFontFromMap(prefs.serif_font_family_map,
+ kCommonScript);
break;
case PP_FONTFAMILY_SANSSERIF:
- resolved_family = prefs.sans_serif_font_family;
+ resolved_family = GetFontFromMap(prefs.sans_serif_font_family_map,
+ kCommonScript);
break;
case PP_FONTFAMILY_MONOSPACE:
- resolved_family = prefs.fixed_font_family;
+ resolved_family = GetFontFromMap(prefs.fixed_font_family_map,
+ kCommonScript);
break;
case PP_FONTFAMILY_DEFAULT:
default:
- resolved_family = prefs.standard_font_family;
+ resolved_family = GetFontFromMap(prefs.standard_font_family_map,
+ kCommonScript);
break;
}
} else {
@@ -119,7 +135,8 @@ WebFontDescription PPFontDescToWebFontDesc(const PP_FontDescription_Dev& font,
// level to detect if the requested font is fixed width, so we only apply
// the alternate font size to the default fixed font family.
if (StringToLowerASCII(resolved_family) ==
- StringToLowerASCII(prefs.fixed_font_family))
+ StringToLowerASCII(GetFontFromMap(prefs.fixed_font_family_map,
+ kCommonScript)))
result.size = static_cast<float>(prefs.default_fixed_font_size);
else
result.size = static_cast<float>(prefs.default_font_size);
@@ -409,4 +426,3 @@ int32_t PPB_Font_Shared::PixelOffsetForCharacter(const PP_TextRun_Dev* text,
}
} // namespace ppapi
-

Powered by Google App Engine
This is Rietveld 408576698