Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 10107001: roll gyp 1325:1330 (Closed)

Created:
8 years, 8 months ago by Nico
Modified:
8 years, 8 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

roll gyp 1325:1330 1326: ninja windows: fix wrappers not outputting with newlines 1327: Support for freebsd 9 1328: mac make/ninja: Add limited support for OTHER_CPLUSPLUSFLAGS. 1329, 1330: Temporarily accept strings as OTHER_CPLUSPLUSFLAGS BUG=none TEST=none TBR=scottmg Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132464

Patch Set 1 #

Patch Set 2 : 1330 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Nico
It's possible this will fail due to http://code.google.com/p/webrtc/source/detail?r=2028 not being rolled into chrome yet. But ...
8 years, 8 months ago (2012-04-16 18:48:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10107001/1
8 years, 8 months ago (2012-04-16 18:49:23 UTC) #2
scottmg
lgtm
8 years, 8 months ago (2012-04-16 19:14:41 UTC) #3
commit-bot: I haz the power
Try job failure for 10107001-1 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-16 19:29:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10107001/1002
8 years, 8 months ago (2012-04-16 20:05:59 UTC) #5
commit-bot: I haz the power
Try job failure for 10107001-1002 on mac_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=18326 Step "update" is always ...
8 years, 8 months ago (2012-04-16 20:12:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10107001/1002
8 years, 8 months ago (2012-04-16 20:19:08 UTC) #7
commit-bot: I haz the power
8 years, 8 months ago (2012-04-16 21:46:06 UTC) #8
Change committed as 132464

Powered by Google App Engine
This is Rietveld 408576698