Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10106022: TabContents -> WebContentsImpl, part 19. (Closed)

Created:
8 years, 8 months ago by Avi (use Gerrit)
Modified:
8 years, 8 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, rdsmith+dwatch_chromium.org
Visibility:
Public.

Description

TabContents -> WebContentsImpl, part 19. BUG=105875 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132599

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -79 lines) Patch
M content/browser/browser_plugin/browser_plugin_web_contents_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/child_process_security_policy_browsertest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M content/browser/download/mhtml_generation_browsertest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/host_zoom_map_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/backing_store_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_browsertest.cc View 1 7 chunks +18 lines, -18 lines 0 comments Download
M content/browser/web_contents/interstitial_page_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/web_contents/web_contents_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/color_chooser.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/interstitial_page.h View 1 chunk +8 lines, -8 lines 0 comments Download
M content/public/browser/web_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_contents_delegate.h View 5 chunks +20 lines, -18 lines 0 comments Download
M content/public/browser/web_contents_delegate.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M content/shell/shell.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/shell.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Avi (use Gerrit)
8 years, 8 months ago (2012-04-17 14:22:03 UTC) #1
jam
lgtm
8 years, 8 months ago (2012-04-17 15:04:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10106022/1
8 years, 8 months ago (2012-04-17 15:16:35 UTC) #3
commit-bot: I haz the power
Try job failure for 10106022-1 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-17 15:42:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10106022/8001
8 years, 8 months ago (2012-04-17 16:36:21 UTC) #5
commit-bot: I haz the power
8 years, 8 months ago (2012-04-17 17:46:18 UTC) #6 
Change committed as 132599

Powered by Google App Engine
This is Rietveld 408576698