remoting/host/constants.h - Issue 10106013: Chromoting: stopping the service if the host ID is permanently not recognized by the could.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/host/constants.h

Issue 10106013: Chromoting: stopping the service if the host ID is permanently not recognized by the could. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef REMOTING_HOST_CONSTANTS_H_

	6 #define REMOTING_HOST_CONSTANTS_H_

	7

	8 namespace remoting {

	9

	10 // Known host exit exit codes.

	11 const int kSuccessExitCode = 0;
	Sergey Ulanov 2012/04/17 17:24:24 Make it enum? Make it enum? alexeypa (please no reviews) 2012/04/17 18:35:53 Done. Show quoted text On 2012/04/17 17:24:24, sergeyu wrote: > Make it enum? Done.
	12 const int kInvalidHostConfigurationExitCode = 1;
	Lambros 2012/04/17 18:04:03 Please could you also update the me2me_virtual_hos Please could you also update the me2me_virtual_host.py script, which currently looks for an exit code of 100 to prevent re-launching? Probably worth adding a comment here, explaining that these codes must match up with me2me_virtual_host.py. That script already has a similar comment pointing here. alexeypa (please no reviews) 2012/04/17 18:35:53 Done. Show quoted text On 2012/04/17 18:04:03, Lambros wrote: > Please could you also update the me2me_virtual_host.py script, which currently > looks for an exit code of 100 to prevent re-launching? Probably worth adding a > comment here, explaining that these codes must match up with > me2me_virtual_host.py. That script already has a similar comment pointing here. Done.
	13 const int kInvalidHostIdExitCode = 2;

	14
	Sergey Ulanov 2012/04/17 17:24:24 Please add one more for invalid OAuth credentials. Please add one more for invalid OAuth credentials. alexeypa (please no reviews) 2012/04/17 17:45:01 You must have been reading my thoughts. I'm actual Show quoted text On 2012/04/17 17:24:24, sergeyu wrote: > Please add one more for invalid OAuth credentials. You must have been reading my thoughts. I'm actually adding it right now. alexeypa (please no reviews) 2012/04/17 18:35:53 Done. Show quoted text On 2012/04/17 17:24:24, sergeyu wrote: > Please add one more for invalid OAuth credentials. Done.
	15 } // namespace remoting

	16

	17 #endif // REMOTING_HOST_CONSTANTS_H_

OLD	NEW

« no previous file with comments | « no previous file | remoting/host/heartbeat_sender.cc » ('j') | remoting/host/wts_session_process_launcher_win.cc » ('J')