Issue 10106011: Fixes FindBar crash. The crash appears to be because if you select a

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10106011: Fixes FindBar crash. The crash appears to be because if you select a (Closed)

Created:
8 years, 8 months ago by sky

Modified:
8 years, 8 months ago

Reviewers:
James Cook

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fixes FindBar crash. The crash appears to be because if you select a discarded tab we don't tell the FindBarController of the new TabContentsWrapper and the FindBar is left referencing the wrong and possibly deleted TabContentsWrapper. BUG=123671 TEST=none R=jamescook@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132518

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -3 lines)			Patch
	M	chrome/browser/oom_priority_manager_browsertest.cc	View		2 chunks	+7 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/browser.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/10106011/1

8 years, 8 months ago (2012-04-17 00:18:59 UTC) #3

Change committed as 132518