chrome/browser/ui/panels/panel_titlebar_view_cocoa.mm - Issue 10106008: Change Panel titlebars to activate the panel on click (rather than minimize).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel_titlebar_view_cocoa.mm

Issue 10106008: Change Panel titlebars to activate the panel on click (rather than minimize). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Mac changes. New test. Ready for review. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/panels/panel_browsertest.cc ('K') | « chrome/browser/ui/panels/panel_browsertest.cc ('k') | chrome/browser/ui/panels/panel_window_controller_cocoa.h » ('j') | chrome/browser/ui/panels/panel_window_controller_cocoa.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/panels/panel_titlebar_view_cocoa.mm

diff --git a/chrome/browser/ui/panels/panel_titlebar_view_cocoa.mm b/chrome/browser/ui/panels/panel_titlebar_view_cocoa.mm

index 71c33cdff1aa7e36f703770feb5373d20fd63c02..df25f5ad659ebb86ea0aa2731785a19504b339fd 100644

--- a/chrome/browser/ui/panels/panel_titlebar_view_cocoa.mm

+++ b/chrome/browser/ui/panels/panel_titlebar_view_cocoa.mm

@@ -62,7 +62,7 @@ static NSEvent* MakeMouseEvent(NSEventType type,

// canceling the reorder by [NSApp preventWindowOrdering] in mouseDown handler

// of this view.

- (BOOL)shouldDelayWindowOrderingForEvent:(NSEvent*)theEvent {

- disableReordering_ = ![controller_ isActivationByClickingTitlebarEnabled];

+ disableReordering_ = ![controller_ canBecomeKeyWindow];

return disableReordering_;

}