Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4307)

Unified Diff: chrome/browser/ui/panels/panel_browser_window_gtk.h

Issue 10106008: Change Panel titlebars to activate the panel on click (rather than minimize). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: GTK changes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel_browser_window_gtk.h
diff --git a/chrome/browser/ui/panels/panel_browser_window_gtk.h b/chrome/browser/ui/panels/panel_browser_window_gtk.h
index aa2808305afd3991bec689c873313632a97b7256..9ffae9a6c5c4b9ea2254599f202de0511b7d57f3 100644
--- a/chrome/browser/ui/panels/panel_browser_window_gtk.h
+++ b/chrome/browser/ui/panels/panel_browser_window_gtk.h
@@ -59,9 +59,6 @@ class PanelBrowserWindowGtk : public BrowserWindowGtk,
virtual void DrawPopupFrame(cairo_t* cr, GtkWidget* widget,
GdkEventExpose* event) OVERRIDE;
virtual void ActiveWindowChanged(GdkWindow* active_window) OVERRIDE;
- // 'focus-in-event' handler.
- virtual void HandleFocusIn(GtkWidget* widget,
- GdkEventFocus* event) OVERRIDE;
// Overridden from NativePanel:
virtual void ShowPanel() OVERRIDE;
@@ -188,15 +185,6 @@ class PanelBrowserWindowGtk : public BrowserWindowGtk,
// Indicates that the panel is currently drawing attention.
bool is_drawing_attention_;
- // Disable ExpansionState changes on mouse click for a short duration.
- // This is needed in case the window gains focus as result of mouseDown while
- // being already expanded and drawing attention - in this case, we don't
- // want to minimize it on subsequent mouseUp.
- // We use time interval because the window may gain focus in various ways
- // (via keyboard for example) which are not distinguishable at this point.
- // Apparently this disable interval is not affecting the user in other cases.
- base::Time disableMinimizeUntilTime_;
-
// Used to animate the bounds change.
scoped_ptr<PanelBoundsAnimation> bounds_animator_;
gfx::Rect animation_start_bounds_;

Powered by Google App Engine
This is Rietveld 408576698