Change Panel titlebars to activate the panel on click (rather than minimize).

chrome/browser/ui/panels/panel.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel.h"
 
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "chrome/browser/ui/panels/docked_panel_strip.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 668 matching lines @@
       content::Source<WebContents>(web_contents));
 }
 
 void Panel::Observe(int type,
                     const content::NotificationSource& source,
                     const content::NotificationDetails& details) {
   DCHECK_EQ(content::NOTIFICATION_WEB_CONTENTS_SWAPPED, type);
   ConfigureAutoResize(content::Source<WebContents>(source).ptr());
 }
 
-void Panel::OnActiveStateChanged() {
+void Panel::OnActiveStateChanged(bool active) {
+  // Clear draw attention state when an expanded panel becomes active.

[jianli, 2012/04/25 18:19:31]

remove "draw" in the comment?

[jennb, 2012/04/25 20:34:05]

Done.

+  // On some systems (e.g. Win), mouse-down activates a panel regardless of
+  // its expansion state. However, we don't want to clear draw attention if
+  // contents are not visible. In that scenario, if the mouse-down results
+  // in a mouse-click, draw attention will be cleared then.
+  // See Panel::OnTitlebarClicked().
+  if (active && IsDrawingAttention() && !IsMinimized())
+    FlashFrame(false);
+
   if (panel_strip_)
     panel_strip_->OnPanelActiveStateChanged(this);
+
+  content::NotificationService::current()->Notify(
+      chrome::NOTIFICATION_PANEL_CHANGED_ACTIVE_STATUS,
+      content::Source<Panel>(this),
+      content::NotificationService::NoDetails());
 }
 
 void Panel::ConfigureAutoResize(WebContents* web_contents) {
   if (!auto_resizable_ || !web_contents)
     return;
 
   // NULL might be returned if the tab has not been added.
   RenderViewHost* render_view_host = web_contents->GetRenderViewHost();
   if (!render_view_host)
     return;
 
   render_view_host->EnableAutoResize(
       min_size_,
       native_panel_->ContentSizeFromWindowSize(max_size_));
 }
 
 void Panel::OnWindowSizeAvailable() {
   ConfigureAutoResize(browser()->GetSelectedWebContents());
 }
 
 void Panel::OnTitlebarClicked(panel::ClickModifier modifier) {
   if (panel_strip_)
     panel_strip_->OnPanelTitlebarClicked(this, modifier);
+
+  // Normally the system activates a window when the titlebar is clicked.
+  // However, we prevent system activation of minimized panels, thus the
+  // activation may not have occurred. Also, some OSes (Windows) will
+  // activate a minimized panel on mouse-down regardless of our attempts to
+  // prevent system activation. Attention state is not cleared in that case.
+  // See Panel::OnActiveStateChanged().
+  // Therefore, we ensure activation and clearing of attention state here.
+  // These are no-ops if no changes are needed.
+  Activate();
+  FlashFrame(false);
 }
 
 void Panel::DestroyBrowser() {
   native_panel_->DestroyPanelBrowser();
 }