Replace string copy code and scoped_arrays() with const_casts in MediaDeviceNotificationsLinuxTest.

chrome/browser/media_gallery/media_device_notifications_linux_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // MediaDeviceNotificationsLinux unit tests.
 
 #include "chrome/browser/media_gallery/media_device_notifications_linux.h"
 
 #include <mntent.h>
 #include <stdio.h>
@@ skipping 21 matching lines @@
 
 const char kInvalidPath[] = "invalid path does not exist";
 
 const char kDevice1[] = "d1";
 const char kDevice2[] = "d2";
 const char kDevice3[] = "d3";
 
 const char kMountPointA[] = "mnt_a";
 const char kMountPointB[] = "mnt_b";
 
-// TODO(thestig) Move this into base/string_util.h, or replace this with
-// strndup_with_new() if we find more uses for it.
-// Duplicate the content of |str| into a new char array. Caller takes ownership
-// of the allocated array. Unlike std::string::c_str(), this returns a char*
-// instead of a const char*.
-char* copy_string(const std::string& str) {
-  const size_t len = str.length();
-  char* ret = new char[len + 1];
-  str.copy(ret, len, 0);
-  ret[len] = '\0';
-  return ret;
-}
-
 class MediaDeviceNotificationsLinuxTestWrapper
     : public MediaDeviceNotificationsLinux {
  public:
   MediaDeviceNotificationsLinuxTestWrapper(const FilePath& path,
                                            MessageLoop* message_loop)
       : MediaDeviceNotificationsLinux(path),
         message_loop_(message_loop) {
   }
 
  private:
@@ skipping 126 matching lines @@
   // Write the test mtab data to |mtab_file_|.
   // |data| is an array of mtab entries.
   // |data_size| is the array size of |data|.
   // |overwrite| specifies whether to overwrite |mtab_file_|.
   void WriteToMtab(const MtabTestData* data,
                    size_t data_size,
                    bool overwrite) {
     FILE* file = setmntent(mtab_file_.value().c_str(), overwrite ? "w" : "a");
     ASSERT_TRUE(file);
 
+    // Due to the glibc *mntent() interface design, which is out of our
+    // control, the mtnent struct has several char* fields, even though
+    // addmntent() does not write to them in the calls below. To make the
+    // compiler happy while avoiding making additional copies of strings,
+    // we just const_cast() the strings' c_str()s.
+    // Assuming addmntent() does not write to the char* fields, this is safe.
+    // It is unlikely the platforms this test suite runs on will have an
+    // addmntent() implementation that does change the char* fields. If that
+    // was ever the case, the test suite will start crashing or failing.
     mntent entry;
-    scoped_array<char> mount_opts(copy_string("rw"));
-    entry.mnt_opts = mount_opts.get();
+    static const char kMountOpts[] = "rw";
+    entry.mnt_opts = const_cast<char*>(kMountOpts);
     entry.mnt_freq = 0;
     entry.mnt_passno = 0;
     for (size_t i = 0; i < data_size; ++i) {
-      scoped_array<char> mount_device(copy_string(data[i].mount_device));
-      scoped_array<char> mount_point(copy_string(data[i].mount_point));
-      scoped_array<char> mount_type(copy_string(data[i].mount_type));
-      entry.mnt_fsname = mount_device.get();
-      entry.mnt_dir = mount_point.get();
-      entry.mnt_type = mount_type.get();
+      entry.mnt_fsname = const_cast<char*>(data[i].mount_device.c_str());
+      entry.mnt_dir = const_cast<char*>(data[i].mount_point.c_str());
+      entry.mnt_type = const_cast<char*>(data[i].mount_type.c_str());
       ASSERT_EQ(0, addmntent(file, &entry));
     }
     ASSERT_EQ(1, endmntent(file));
   }
 
   // The message loop and file thread to run tests on.
   MessageLoop message_loop_;
   content::TestBrowserThread file_thread_;
 
   // SystemMonitor and DevicesChangedObserver to hook together to test.
@@ skipping 164 matching lines @@
 
   // Detach all devices.
   EXPECT_CALL(observer(), OnMediaDeviceAttached(_, _, _)).Times(0);
   EXPECT_CALL(observer(), OnMediaDeviceDetached(1)).Times(1);
   WriteEmptyMtabAndRunLoop();
 }
 
 }  // namespace
 
 }  // namespace chrome