Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10105013: ModuleSystem should not crash when JS has a syntax error. (Closed)

Created:
8 years, 8 months ago by Aaron Boodman
Modified:
8 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

ModuleSystem should not crash when JS has a syntax error. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132515

Patch Set 1 #

Patch Set 2 : blah #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M chrome/renderer/module_system.cc View 1 5 chunks +28 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Aaron Boodman
8 years, 8 months ago (2012-04-16 23:41:52 UTC) #1
koz (OOO until 15th September)
lgtm
8 years, 8 months ago (2012-04-16 23:59:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/10105013/2001
8 years, 8 months ago (2012-04-17 00:04:30 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-17 02:11:34 UTC) #4 
Change committed as 132515

Powered by Google App Engine
This is Rietveld 408576698