Issue 10105006: sync: sprinkle extra asserts to hunt down bug 121587

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10105006: sync: sprinkle extra asserts to hunt down bug 121587 (Closed)

Created:
8 years, 8 months ago by tim (not reviewing)

Modified:
8 years, 8 months ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

sync: sprinkle extra asserts to hunt down bug 121587 Break down the single unrecoverable error into 4 cases. BUG=121587 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132480

Patch Set 1 #

Total comments: 1

Patch Set 2 : review #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -2 lines)			Patch
	M	chrome/browser/sync/glue/bookmark_change_processor.cc	View	1	2 chunks	+17 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nicolas Zea

LGTM with nit http://codereview.chromium.org/10105006/diff/1/chrome/browser/sync/glue/bookmark_change_processor.cc File chrome/browser/sync/glue/bookmark_change_processor.cc (right): http://codereview.chromium.org/10105006/diff/1/chrome/browser/sync/glue/bookmark_change_processor.cc#newcode219 chrome/browser/sync/glue/bookmark_change_processor.cc:219: if (!model_associator_->GetSyncIdFromChromeId(node->id())) { if (... == ...

8 years, 8 months ago (2012-04-16 20:48:28 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tim@chromium.org/10105006/4

8 years, 8 months ago (2012-04-16 21:01:42 UTC) #3

Change committed as 132480

Expand Messages | Collapse Messages