Share optimized code for closures.

src/factory.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 542 matching lines @@
   if (!function_info->bound()) {
     int number_of_literals = function_info->num_literals();
     Handle<FixedArray> literals = NewFixedArray(number_of_literals, pretenure);
     if (number_of_literals > 0) {
       // Store the object, regexp and array functions in the literals
       // array prefix.  These functions will be used when creating
       // object, regexp and array literals in this function.
       literals->set(JSFunction::kLiteralGlobalContextIndex,
                     context->global_context());
     }
     result->set_literals(*literals);

[fschneider, 2012/04/20 14:05:43]

Instead of always allocating a new literals array, check if we can use a shared
literals array from the optimized code map stored, similar to the way we lookup
shared optimized code.

The same strategy has to be implemented for the FastNewClosureStub.

   }
+
+  if (FLAG_cache_optimized_code) {
+    Code* code =
+        function_info->SearchOptimizedCodeMap(context->global_context());
+    if (code != NULL) {
+      result->ReplaceCode(code);
+      return result;
+    }
+  }
+  result->set_next_function_link(isolate()->heap()->undefined_value());

[fschneider, 2012/04/20 14:05:43]

Not needed since next_function_link is already initialized in
Heap::AllocateFunction.

+
   if (V8::UseCrankshaft() &&
       FLAG_always_opt &&
       result->is_compiled() &&
       !function_info->is_toplevel() &&
       function_info->allows_lazy_compilation() &&
       !function_info->optimization_disabled()) {
     result->MarkForLazyRecompilation();
   }
   return result;
 }
@@ skipping 865 matching lines @@
 
 
 Handle<Object> Factory::ToBoolean(bool value) {
   return Handle<Object>(value
                         ? isolate()->heap()->true_value()
                         : isolate()->heap()->false_value());
 }
 
 
 } }  // namespace v8::internal