Only do DelegateExecute verb handler registration for Google Chrome.

Only do DelegateExecute verb handler registration for Google Chrome.

Don't do it for canary, which can't be made the default browser anyway, or for Chromium, which needs its own handler registration; see the associated bug.

BUG=123727
TEST=install SxS Chrome and/or Chromium and confirm that the DelegateExecute handler is not registered (chrome_installer.log should say "No DelegateExecute verb handler processing to do for ...")


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132596

[grt (UTC plus 2), 2012-04-17 02:13:38]

WDYT of this approach, Robert?

[robertshield, 2012-04-17 14:51:18]

Approach LGTM, nits

http://codereview.chromium.org/10103020/diff/2004/chrome/installer/setup/inst...
File chrome/installer/setup/install_worker.cc (right):

http://codereview.chromium.org/10103020/diff/2004/chrome/installer/setup/inst...
chrome/installer/setup/install_worker.cc:1045: &type_lib_uuid,
&type_lib_version, &interface_uuid)) {
indent + 4

http://codereview.chromium.org/10103020/diff/2004/chrome/installer/setup/unin...
File chrome/installer/setup/uninstall.cc (right):

http://codereview.chromium.org/10103020/diff/2004/chrome/installer/setup/unin...
chrome/installer/setup/uninstall.cc:819:
ProcessDelegateExecuteWorkItems(original_state, installer_state, setup_path,
perhaps a clarifying comment here on near the implementation mentioning that
this is a no-op for products that don't have delegate execute work items

http://codereview.chromium.org/10103020/diff/2004/chrome/installer/util/util_...
File chrome/installer/util/util_constants.cc (right):

http://codereview.chromium.org/10103020/diff/2004/chrome/installer/util/util_...
chrome/installer/util/util_constants.cc:182: const wchar_t kPSOAInterfaceUuid[]
= L"{00020424-0000-0000-C000-000000000046}";
can this be found in a system header somewhere? also the constant name is very
obscure.

[grt (UTC plus 2), 2012-04-17 15:27:33]

Thanks.  Nits addressed; PTAL.

http://codereview.chromium.org/10103020/diff/2004/chrome/installer/setup/inst...
File chrome/installer/setup/install_worker.cc (right):

http://codereview.chromium.org/10103020/diff/2004/chrome/installer/setup/inst...
chrome/installer/setup/install_worker.cc:1045: &type_lib_uuid,
&type_lib_version, &interface_uuid)) {
On 2012/04/17 14:51:19, robertshield wrote:
> indent + 4

Done.

http://codereview.chromium.org/10103020/diff/2004/chrome/installer/setup/unin...
File chrome/installer/setup/uninstall.cc (right):

http://codereview.chromium.org/10103020/diff/2004/chrome/installer/setup/unin...
chrome/installer/setup/uninstall.cc:819:
ProcessDelegateExecuteWorkItems(original_state, installer_state, setup_path,
On 2012/04/17 14:51:19, robertshield wrote:
> perhaps a clarifying comment here on near the implementation mentioning that
> this is a no-op for products that don't have delegate execute work items

Done.

http://codereview.chromium.org/10103020/diff/2004/chrome/installer/util/util_...
File chrome/installer/util/util_constants.cc (right):

http://codereview.chromium.org/10103020/diff/2004/chrome/installer/util/util_...
chrome/installer/util/util_constants.cc:182: const wchar_t kPSOAInterfaceUuid[]
= L"{00020424-0000-0000-C000-000000000046}";
On 2012/04/17 14:51:19, robertshield wrote:
> can this be found in a system header somewhere? also the constant name is very
> obscure.

I can't find it anywhere.  I've added a comment.

[robertshield, 2012-04-17 16:03:05]

lgtm

http://codereview.chromium.org/10103020/diff/4002/chrome/installer/util/util_...
File chrome/installer/util/util_constants.cc (right):

http://codereview.chromium.org/10103020/diff/4002/chrome/installer/util/util_...
chrome/installer/util/util_constants.cc:182: // The CLSID of the proxy stub OLE
Automation universal marshaler;  the default
";  " -> ", "

[commit-bot: I haz the power, 2012-04-17 16:08:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grt@chromium.org/10103020/11001

[commit-bot: I haz the power, 2012-04-17 16:08:38]

Can't apply patch for file chrome/installer/setup/uninstall.cc.
While running patch -p1 --forward --force;
patching file chrome/installer/setup/uninstall.cc
Hunk #1 FAILED at 689.
1 out of 3 hunks FAILED -- saving rejects to file
chrome/installer/setup/uninstall.cc.rej

[commit-bot: I haz the power, 2012-04-17 16:16:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grt@chromium.org/10103020/12001

[commit-bot: I haz the power, 2012-04-17 17:38:56]

Change committed as 132596