Issue 10103016: Move PepperNetworkManager to client/plugin

Issue 10103016: Move PepperNetworkManager to client/plugin (Closed)

Created:
8 years, 8 months ago by Sergey Ulanov

Modified:
8 years, 8 months ago

Reviewers:
Wez

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move PepperNetworkManager to client/plugin Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132533

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -175 lines)			Patch
A +	remoting/client/plugin/pepper_network_manager.h	View	1	3 chunks	+3 lines, -5 lines	0 comments	Download
A +	remoting/client/plugin/pepper_network_manager.cc	View		3 chunks	+1 line, -3 lines	0 comments	Download
D	remoting/protocol/pepper_network_manager.h	View		1 chunk	+0 lines, -51 lines	0 comments	Download
D	remoting/protocol/pepper_network_manager.cc	View		1 chunk	+0 lines, -114 lines	0 comments	Download
M	remoting/remoting.gyp	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Wez

lgtm http://codereview.chromium.org/10103016/diff/1/remoting/client/plugin/pepper_network_manager.h File remoting/client/plugin/pepper_network_manager.h (right): http://codereview.chromium.org/10103016/diff/1/remoting/client/plugin/pepper_network_manager.h#newcode6 remoting/client/plugin/pepper_network_manager.h:6: #define REMOTING_PROTOCOL_PEPPER_NETWORK_MANAGER_H_ Update the guard name. http://codereview.chromium.org/10103016/diff/1/remoting/client/plugin/pepper_network_manager.h#newcode49 remoting/client/plugin/pepper_network_manager.h:49: ...

8 years, 8 months ago (2012-04-17 01:06:06 UTC) #2

Sergey Ulanov

http://codereview.chromium.org/10103016/diff/1/remoting/client/plugin/pepper_network_manager.h File remoting/client/plugin/pepper_network_manager.h (right): http://codereview.chromium.org/10103016/diff/1/remoting/client/plugin/pepper_network_manager.h#newcode6 remoting/client/plugin/pepper_network_manager.h:6: #define REMOTING_PROTOCOL_PEPPER_NETWORK_MANAGER_H_ On 2012/04/17 01:06:06, Wez wrote: > Update ...

8 years, 8 months ago (2012-04-17 01:32:57 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10103016/2002

8 years, 8 months ago (2012-04-17 01:33:15 UTC) #4

Change committed as 132533

Expand Messages | Collapse Messages