[Chromoting] Implement UpdateConfig() for the Windows host.

remoting/host/elevated_controller_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/elevated_controller_win.h"
 
 #include <sddl.h>
 
 #include "base/file_util.h"
 #include "base/logging.h"
@@ skipping 26 matching lines @@
 // reasonable configuration we will ever need. 1MB is low enough to make
 // the probability of out of memory situation fairly low. OOM is still possible
 // and we will crash if it occurs.
 const size_t kMaxConfigFileSize = 1024 * 1024;
 
 // ReadConfig() filters the configuration file stripping all variables except of
 // the following two.
 const char kHostId[] = "host_id";
 const char kXmppLogin[] = "xmpp_login";
 
+// The configuration keys that cannot be specified in UpdateConfig().
+const char* kReadonlyKeys[] = { kHostId, kXmppLogin };

[Sergey Ulanov, 2012/04/17 05:42:18]

nit: const char* const kReadonlyKeys[]

[simonmorris, 2012/04/17 15:55:47]

Done.

+
 // Reads and parses the configuration file up to |kMaxConfigFileSize| in
 // size.
 HRESULT ReadConfig(const FilePath& filename,
                    scoped_ptr<base::DictionaryValue>* config_out) {
 
   // Read raw data from the configuration file.
   base::win::ScopedHandle file(
       CreateFileW(filename.value().c_str(),
                   GENERIC_READ,
                   FILE_SHARE_READ | FILE_SHARE_WRITE,
@@ skipping 263 matching lines @@
       LOG_GETLASTERROR(ERROR)
           << "Failed to stop the '" << kWindowsServiceName << "'service";
       return HRESULT_FROM_WIN32(error);
     }
   }
 
   return S_OK;
 }
 
 STDMETHODIMP ElevatedControllerWin::UpdateConfig(BSTR config) {
-  return E_NOTIMPL;
+  // Parse the config.
+  std::string config_str = UTF16ToUTF8(
+    string16(static_cast<char16*>(config), ::SysStringLen(config)));
+  scoped_ptr<base::Value> config_value(base::JSONReader::Read(config_str));
+  if (!config_value.get()) {
+    return E_FAIL;
+  }
+  base::DictionaryValue* config_dict = NULL;
+  if (!config_value->GetAsDictionary(&config_dict)) {
+    return E_FAIL;
+  }
+  // Check for bad keys.
+  for (int i = 0; i < arraysize(kReadonlyKeys); ++i) {
+    if (config_dict->HasKey(kReadonlyKeys[i])) {

[Sergey Ulanov, 2012/04/17 05:42:18]

Not sure if this is really necessary to verify this here - HostScriptableObject
should check it. Or is this to make sure that the COM interface is not abused by
some other malicious  code?

[alexeypa (please no reviews), 2012/04/17 05:51:54]

Yes, pretty much. This check has to be on the more privileged side to make sure
it is secure.

+      return HRESULT_FROM_WIN32(ERROR_ACCESS_DENIED);
+    }
+  }
+  // Get the old config.
+  FilePath config_dir = remoting::GetConfigDir();
+  scoped_ptr<base::DictionaryValue> config_old;
+  HRESULT hr = ReadConfig(config_dir.Append(kConfigFileName), &config_old);
+  if (FAILED(hr)) {
+    return hr;
+  }
+  // Merge items from the given config into the old config.
+  config_old->MergeDictionary(config_dict);
+  // Write the updated config.
+  std::string config_updated_str;
+  base::JSONWriter::Write(config_old.get(), &config_updated_str);
+  return WriteConfig(config_dir.Append(kConfigFileName),
+                     config_updated_str.c_str(),
+                     config_updated_str.size());
 }
 
 HRESULT ElevatedControllerWin::OpenService(ScopedScHandle* service_out) {
   DWORD error;
 
   ScopedScHandle scmanager(
       ::OpenSCManagerW(NULL, SERVICES_ACTIVE_DATABASE,
                        SC_MANAGER_CONNECT | SC_MANAGER_ENUMERATE_SERVICE));
   if (!scmanager.IsValid()) {
     error = GetLastError();
@@ skipping 13 matching lines @@
         << "Failed to open to the '" << kWindowsServiceName << "' service";
 
     return HRESULT_FROM_WIN32(error);
   }
 
   service_out->Set(service.Take());
   return S_OK;
 }
 
 } // namespace remoting