Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5554)

Unified Diff: chrome/test/data/extensions/api_test/downloads/test.js

Issue 10103004: Disallow slashes in filename in downloads.download() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: " Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/download_extension_api.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/downloads/test.js
diff --git a/chrome/test/data/extensions/api_test/downloads/test.js b/chrome/test/data/extensions/api_test/downloads/test.js
index a31dee5aa8f146575592bd9132472dd77828293e..a26e591bb6b3a1b68874edd991f9b520e93e24f4 100644
--- a/chrome/test/data/extensions/api_test/downloads/test.js
+++ b/chrome/test/data/extensions/api_test/downloads/test.js
@@ -588,6 +588,14 @@ chrome.test.getConfig(function(testConfig) {
}));
},
+ // TODO(benjhayden): Update this test when downloading to sub-directories is
+ // supported.
+ function downloadFilenameDisallowSlashes() {
+ downloads.download(
+ {'url': SAFE_FAST_URL, 'filename': 'subdirectory/file.txt'},
+ chrome.test.callbackFail(downloads.ERROR_GENERIC));
+ },
+
function downloadOnCreated() {
// Test that the onCreated event fires when we start a download.
var downloadId = getNextId();
« no previous file with comments | « chrome/browser/download/download_extension_api.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698