Issue 101016: Improve register allocation of left shift operation. Add tests...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 101016: Improve register allocation of left shift operation. Add tests... (Closed)

Created:
11 years, 7 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Improve register allocation of left shift operation. Add tests for all shift operations. Committed: http://code.google.com/p/v8/source/detail?r=1825

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+410 lines, -19 lines)			Patch
	M	src/ia32/codegen-ia32.cc	View	1 2	4 chunks	+19 lines, -18 lines	0 comments	Download
	M	test/mjsunit/smi-ops.js	View	1 2	2 chunks	+391 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

11 years, 7 months ago (2009-04-29 14:17:27 UTC) #2

LGTM.  I have to confess that I didn't read every line of the tests.

http://codereview.chromium.org/101016/diff/2001/1002
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/101016/diff/2001/1002#newcode5908
Line 5908: *left = answer;
Indentation?

Expand Messages | Collapse Messages