Issue 101013: Migrating the SSL UI tests to be browser tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 101013: Migrating the SSL UI tests to be browser tests (Closed)

Created:
11 years, 8 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Migrating the SSL UI tests to be browser tests. Reenabling all of them. Hopefully it'll help with flakiness. Note that I am keeping the SSL UI tests alive until the browser test framework has been ported to Mac and Linux. BUG=6584, 2136 TEST=Run the browser tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14901

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Total comments: 2

Patch Set 7 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+897 lines, -86 lines)			Patch
M	chrome/browser/browser_focus_uitest.cc	View		2 chunks	+8 lines, -6 lines	0 comments	Download
M	chrome/browser/ssl/ssl_browser_tests.cc	View	1 2 3 4 5 6	1 chunk	+763 lines, -8 lines	0 comments	Download
M	chrome/browser/tab_contents/navigation_entry.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.h	View	1 2 3 4 5 6	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/views/find_bar_win_browsertest.cc	View		2 chunks	+9 lines, -6 lines	0 comments	Download
M	chrome/test/data/ssl/google.html	View	1 2 3 4 5 6	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/ui_test_utils.h	View	1 2 3 4 5	2 chunks	+27 lines, -32 lines	0 comments	Download
M	chrome/test/ui_test_utils.cc	View	1 2 3 4 5 6	3 chunks	+84 lines, -31 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

11 years, 7 months ago (2009-04-29 16:17:29 UTC) #2

LGTM with the following changes.

http://codereview.chromium.org/101013/diff/2025/3054
File chrome/browser/tab_contents/tab_contents.h (right):

http://codereview.chromium.org/101013/diff/2025/3054#newcode362
Line 362: int GetConstrainedWindowCount() { return child_windows_.size(); }
Should this be constrained_window_count() ? And don't you need a static_cast, or
possibly just return a size_t?

http://codereview.chromium.org/101013/diff/2025/3052
File chrome/test/ui_test_utils.cc (right):

http://codereview.chromium.org/101013/diff/2025/3052#newcode74
Line 74: RunMessageLoop();
nit: spacing is wrong here.

Expand Messages | Collapse Messages