Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issue 101009: Always simulate a mouse movement after animations in the Linux tabstrip to ma... (Closed)

Created:
11 years, 8 months ago by James Hawkins
Modified:
9 years, 7 months ago
Reviewers:
tony
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Always simulate a mouse movement after animations in the Linux tabstrip to make sure we never have a stale hover index. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14743

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -23 lines) Patch
M chrome/browser/gtk/tabs/tab_strip_gtk.cc View 1 3 chunks +19 lines, -23 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
James Hawkins
11 years, 8 months ago (2009-04-28 17:17:18 UTC) #1
tony
Rather than simulating a mouse move, can't we call directly into the OnMotionNotify function? It's ...
11 years, 8 months ago (2009-04-28 17:27:24 UTC) #2
James Hawkins
On 2009/04/28 17:27:24, tony wrote: > Rather than simulating a mouse move, can't we call ...
11 years, 8 months ago (2009-04-28 17:34:09 UTC) #3
tony
11 years, 8 months ago (2009-04-28 17:41:16 UTC) #4
Ok, if you promise that this hack won't appear in the refactor.  It makes it
harder to debug if it jumps back and forth between gtk and our code.

On 2009/04/28 17:34:09, James Hawkins wrote:
> On 2009/04/28 17:27:24, tony wrote:
> > Rather than simulating a mouse move, can't we call directly into the
> > OnMotionNotify function?  It's kind of awkward since it takes params that
you
> > don't have, but maybe you could refactor OnMotionNotify to call a new method
> on
> > TabStripGtk that only takes the parts of |event| that you need?
> 
> I did think about that option, but I'd rather not for a few reasons.
> * This is how it's done in Windows.
> * Adding a wrapper that we can call too is awkward.
> * I forgot to add a TODO that says this will all go away when I make each tab
a
> widget (which will be happening soon).
> 
> So I'd like to keep it this way, with an added TODO and then work on making
each
> tab a widget, which will move all of this hovering hack disappear.

Powered by Google App Engine
This is Rietveld 408576698