Adds a new API for launching Chrome at a given size and location. ...

Adds a new API for launching Chrome at a given size and location.  
This only works with post-1.0 Chrome, as it refers to the new Window names.

R=kuchhal


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14906

[Glenn Wilson, 2009-04-28 17:21:56]

http://codereview.chromium.org/101008/diff/1/2
File chrome/installer/gcapi/gcapi.cc (right):

http://codereview.chromium.org/101008/diff/1/2#newcode412
Line 412: #pragma comment(linker,
"/EXPORT:LaunchGoogleChromeWithDimensions=_LaunchGoogleChromeWithDimensions@16,PRIVATE")
How can I break this line up?

[kuchhal, 2009-04-28 17:36:43]

http://codereview.chromium.org/101008/diff/1/2
File chrome/installer/gcapi/gcapi.cc (right):

http://codereview.chromium.org/101008/diff/1/2#newcode412
Line 412: #pragma comment(linker,
"/EXPORT:LaunchGoogleChromeWithDimensions=_LaunchGoogleChromeWithDimensions@16,PRIVATE")
I think its fine to leave it (some exceptions are allowed to 80 char limit
rule).
On 2009/04/28 17:21:56, gwilson wrote:
> How can I break this line up?

http://codereview.chromium.org/101008/diff/1/2#newcode425
Line 425: handle = FindWindowEx(NULL, handle, L"Chrome_WidgetWin_0", NULL);
Chrome could also have been launched already but we would still end up sleeping
for a second. May we should do a FindWindow first and if handle is invalid then
sleep. Also it might be safe to put an additional exit condition. For example if
Chrome crashes on startup this loop will get stuck.

I guess we do not care about the stable branch any more (the window name is
different for that)?

http://codereview.chromium.org/101008/diff/1/2#newcode435
Line 435: handle = FindWindowEx(NULL, handle, L"Chrome_WidgetWin_0", NULL);
Hmm.. I am not entirely sure what this loop is doing.

http://codereview.chromium.org/101008/diff/1/3
File chrome/installer/gcapi/gcapi.h (right):

http://codereview.chromium.org/101008/diff/1/3#newcode42
Line 42: DLLEXPORT BOOL __stdcall LaunchGoogleChromeWithDimensions(int x, int y,
int width, int height);
more than 80 chars.

http://codereview.chromium.org/101008/diff/1/3#newcode47
Line 47: typedef BOOL (__stdcall * GCCC_LaunchGCWithDimentions)(int, int, int,
int);
spelling typo

[Glenn Wilson, 2009-04-28 20:29:33]

http://codereview.chromium.org/101008/diff/1/2
File chrome/installer/gcapi/gcapi.cc (right):

http://codereview.chromium.org/101008/diff/1/2#newcode425
Line 425: handle = FindWindowEx(NULL, handle, L"Chrome_WidgetWin_0", NULL);
On 2009/04/28 17:36:43, kuchhal wrote:
> Chrome could also have been launched already but we would still end up
sleeping
> for a second. May we should do a FindWindow first and if handle is invalid
then
> sleep. Also it might be safe to put an additional exit condition. For example
if
> Chrome crashes on startup this loop will get stuck.
> 
> I guess we do not care about the stable branch any more (the window name is
> different for that)?

Ok, I reversed the lookup and the Sleep() and added a 10-second timeout.  

I made the assumption that we will only need this for the beta branch on.

http://codereview.chromium.org/101008/diff/1/2#newcode435
Line 435: handle = FindWindowEx(NULL, handle, L"Chrome_WidgetWin_0", NULL);
On 2009/04/28 17:36:43, kuchhal wrote:
> Hmm.. I am not entirely sure what this loop is doing. 

I modified the comment before this loop to be a little clearer.

This loop iterates through each top-level window named Chrome_WidgetWin_0 and
checks if it has children.  If it finds a window with this name that has
Children, that is the window we want.  I added a conditional to the while() to
prevent it from getting into an infinite loop.

http://codereview.chromium.org/101008/diff/1/3
File chrome/installer/gcapi/gcapi.h (right):

http://codereview.chromium.org/101008/diff/1/3#newcode42
Line 42: DLLEXPORT BOOL __stdcall LaunchGoogleChromeWithDimensions(int x, int y,
int width, int height);
On 2009/04/28 17:36:43, kuchhal wrote:
> more than 80 chars.

Done.

http://codereview.chromium.org/101008/diff/1/3#newcode47
Line 47: typedef BOOL (__stdcall * GCCC_LaunchGCWithDimentions)(int, int, int,
int);
On 2009/04/28 17:36:43, kuchhal wrote:
> spelling typo

Done.

[kuchhal, 2009-04-28 21:54:32]

lgtm.

http://codereview.chromium.org/101008/diff/3002/2004
File chrome/installer/gcapi/gcapi.cc (right):

http://codereview.chromium.org/101008/diff/3002/2004#newcode435
Line 435: return false;
reduce indentation by two spaces.