Ensure Windows window classes are unregistered on shutdown (take 2)

Relanding this. 
The Ole unitialization was failing on one of the Vista build-bot.
It is not clear when the Ole initialization is balanced when a CRichEditCtrl is created/destructed.
So I now turn it off explicitly.

This CL makes sure we unregister our Windows window classes when shut-down.
It also balances-out an OLE initialization performed by the CRichEditCTRL.

This is necessary for allowing to reload chrome.dll in a process, which is what
the browser tests will do.

BUG=None
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14649

[M-A Ruel, 2009-04-25 13:14:39]

Almost lgtm:
- Fix the copyright dates
- Don't make the member variable a static member.

Don't change the GetModuleHandle(NULL) in this change, but it should be done in
a later check-in (fairly straightforward)

http://codereview.chromium.org/101004/diff/1/5
File base/message_pump_win.cc (right):

http://codereview.chromium.org/101004/diff/1/5#newcode1
Line 1: // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2009

http://codereview.chromium.org/101004/diff/1/5#newcode91
Line 91: UnregisterClass(kWndClass, GetModuleHandle(NULL));
Oh
I realize, GetModuleHandle(NULL) is probably wrong here. It should be
&__ImageBase (or the macro equivalent) instead.

http://codereview.chromium.org/101004/diff/1/2
File chrome/browser/process_singleton_win.cc (right):

http://codereview.chromium.org/101004/diff/1/2#newcode140
Line 140: HINSTANCE hinst = GetModuleHandle(NULL);
Anyway, I just recommend to take a look in a later checkin. I don't understand
why this code works since it returns the handle to chrome.exe (or even worse for
the in-process tests)

http://codereview.chromium.org/101004/diff/1/3
File chrome/views/widget/widget_win.cc (right):

http://codereview.chromium.org/101004/diff/1/3#newcode80
Line 80: for (RegisteredClasses::iterator i = registered_classes_.begin();
nit: const_iterator ?

http://codereview.chromium.org/101004/diff/1/3#newcode127
Line 127: static int registered_count_;
NO! Not static! It's _already_ a singleton.

[jcampan, 2009-04-27 20:27:33]

OK, the Ole unbalancing created by CRichEditCtrl is now dealt with when the DLL
is unloaded. (see DllMain in other CL
http://codereview.chromium.org/88066/diff/5001/5003).

As you suggestsed, I'll deal with the GetModule() later.

http://codereview.chromium.org/101004/diff/1/5
File base/message_pump_win.cc (right):

http://codereview.chromium.org/101004/diff/1/5#newcode1
Line 1: // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
On 2009/04/25 13:14:39, M-A wrote:
> 2009

Done.

http://codereview.chromium.org/101004/diff/1/3
File chrome/views/widget/widget_win.cc (right):

http://codereview.chromium.org/101004/diff/1/3#newcode80
Line 80: for (RegisteredClasses::iterator i = registered_classes_.begin();
On 2009/04/25 13:14:39, M-A wrote:
> nit: const_iterator ?

Done.

http://codereview.chromium.org/101004/diff/1/3#newcode127
Line 127: static int registered_count_;
On 2009/04/25 13:14:39, M-A wrote:
> NO! Not static! It's _already_ a singleton.
OK

[M-A Ruel, 2009-04-27 20:33:08]

lgtm