Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1510)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10097014: Display the extension id and name when its installation is refused by policy. (Closed)

Created:
8 years, 8 months ago by Joao da Silva
Modified:
8 years, 8 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org
Visibility:
Public.

Description

Display the extension id and name when its installation is refused by policy. BUG=123381 TEST=Try to install a blacklisted extension. The error message and the log detail the extension name and id. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132437

Patch Set 1 #

Total comments: 2

Patch Set 2 : Dropped the with. It's cleaner. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Joao da Silva
8 years, 8 months ago (2012-04-16 14:32:30 UTC) #1
Mattias Nissler (ping if slow)
LGTM http://codereview.chromium.org/10097014/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/10097014/diff/1/chrome/app/generated_resources.grd#newcode4338 chrome/app/generated_resources.grd:4338: + <ph name="EXTENSION_NAME">$1<ex>Google Talk</ex></ph> (with extension ID "<ph ...
8 years, 8 months ago (2012-04-16 14:34:02 UTC) #2
Joao da Silva
http://codereview.chromium.org/10097014/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/10097014/diff/1/chrome/app/generated_resources.grd#newcode4338 chrome/app/generated_resources.grd:4338: + <ph name="EXTENSION_NAME">$1<ex>Google Talk</ex></ph> (with extension ID "<ph name="EXTENSION_ID">$2<ex>nckgahadagoaajjgafhacjanaoiihapd</ex></ph>") ...
8 years, 8 months ago (2012-04-16 14:39:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/10097014/6
8 years, 8 months ago (2012-04-16 16:56:04 UTC) #4
commit-bot: I haz the power
8 years, 8 months ago (2012-04-16 19:13:36 UTC) #5 
Change committed as 132437

Powered by Google App Engine
This is Rietveld 408576698