Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 10097004: Moved Linux specific shell integration declarations into own header. (Closed)

Created:
8 years, 8 months ago by benwells
Modified:
8 years, 8 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, sail
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Moved Linux specific shell integration declarations into own header. This continues refactoring started in http://codereview.chromium.org/9958006/ BUG=None TEST=Refactor; covered by existing tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132489

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -86 lines) Patch
M chrome/browser/background/background_mode_manager_gtk.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/shell_integration.h View 2 chunks +0 lines, -34 lines 0 comments Download
M chrome/browser/shell_integration_linux.h View 1 chunk +30 lines, -0 lines 0 comments Download
M chrome/browser/shell_integration_linux.cc View 8 chunks +28 lines, -33 lines 0 comments Download
M chrome/browser/shell_integration_unittest.cc View 6 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/unity_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/web_applications/web_app_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
benwells
8 years, 8 months ago (2012-04-16 05:07:34 UTC) #1
Elliot Glaysher
lgtm
8 years, 8 months ago (2012-04-16 18:12:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/10097004/1
8 years, 8 months ago (2012-04-16 22:32:17 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-17 00:28:58 UTC) #4
Change committed as 132489

Powered by Google App Engine
This is Rietveld 408576698