Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 10096017: Partially reland r131930. Only assert on system context leaks this time. (Closed)

Created:
8 years, 8 months ago by willchan no longer on Chromium
Modified:
8 years, 8 months ago
Reviewers:
eroman
CC:
chromium-reviews
Visibility:
Public.

Description

Partially reland r131930. Only assert on system context leaks this time. Original CL: ========== Assert we do not leak requests for the system and safe browsing contexts. It's possible this will catch some leaks when deployed live. We should be able to analyze the crash dumps and fix the culprits. ========== This time, I'll only assert we do not leak requests for the system request context, since I've confirmed that we are leaking requests for the safe browsing context. BUG=90971 TEST=None TBR=eroman Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132531

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/io_thread.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
willchan no longer on Chromium
8 years, 8 months ago (2012-04-16 17:34:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/willchan@chromium.org/10096017/1
8 years, 8 months ago (2012-04-16 18:22:11 UTC) #2
commit-bot: I haz the power
Try job failure for 10096017-1 (retry) on linux_rel for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-16 18:55:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/willchan@chromium.org/10096017/1
8 years, 8 months ago (2012-04-17 00:32:10 UTC) #4
commit-bot: I haz the power
8 years, 8 months ago (2012-04-17 04:35:43 UTC) #5
Change committed as 132531

Powered by Google App Engine
This is Rietveld 408576698