Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10096012: [cros] Add Ctrl+Alt+E shortcut to Welcome/EULA screen that cancels update and starts with enrollment (Closed)

Created:
8 years, 8 months ago by Nikita (slow)
Modified:
8 years, 8 months ago
Reviewers:
Ivan Korotkov
CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, Joao da Silva
Visibility:
Public.

Description

[cros] Add Ctrl+Alt+E shortcut to Welcome/EULA screen that cancels update and starts with enrollment Also fixes couple of style errors in display_manager.js + renamed virtual members. BUG=121010 TEST=Manual. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132469

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 1

Patch Set 3 : move to CoreOobeHandler #

Patch Set 4 : fix #

Total comments: 2

Patch Set 5 : add postUpdateActions #

Patch Set 6 : add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -32 lines) Patch
M chrome/browser/chromeos/login/eula_screen.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/mock_screen_observer.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screen_observer.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 1 2 3 4 3 chunks +16 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 2 3 4 5 chunks +25 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 1 2 3 4 5 4 chunks +34 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/display_manager.js View 2 chunks +19 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc View 1 2 3 chunks +17 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Nikita (slow)
http://codereview.chromium.org/10096012/diff/2001/chrome/browser/chromeos/login/wizard_controller.cc File chrome/browser/chromeos/login/wizard_controller.cc (right): http://codereview.chromium.org/10096012/diff/2001/chrome/browser/chromeos/login/wizard_controller.cc#newcode503 chrome/browser/chromeos/login/wizard_controller.cc:503: host_->CheckForAutoEnrollment(); Joao: Even though we'll be starting auto enrollment ...
8 years, 8 months ago (2012-04-16 16:24:47 UTC) #1
Nikita (slow)
Joao: FYI on enrollment. This should not affect auto enrollment.
8 years, 8 months ago (2012-04-16 16:25:24 UTC) #2
Ivan Korotkov
lgtm http://codereview.chromium.org/10096012/diff/5001/chrome/browser/resources/chromeos/login/display_manager.js File chrome/browser/resources/chromeos/login/display_manager.js (right): http://codereview.chromium.org/10096012/diff/5001/chrome/browser/resources/chromeos/login/display_manager.js#newcode100 chrome/browser/resources/chromeos/login/display_manager.js:100: chrome.send('skipUpdateEnrollAfterEula'); Suggestion: indicate somehow that we've activated a ...
8 years, 8 months ago (2012-04-16 16:42:13 UTC) #3
Nikita (slow)
+ Added PerformPostUpdateActions() http://codereview.chromium.org/10096012/diff/5001/chrome/browser/resources/chromeos/login/display_manager.js File chrome/browser/resources/chromeos/login/display_manager.js (right): http://codereview.chromium.org/10096012/diff/5001/chrome/browser/resources/chromeos/login/display_manager.js#newcode100 chrome/browser/resources/chromeos/login/display_manager.js:100: chrome.send('skipUpdateEnrollAfterEula'); On 2012/04/16 16:42:14, Ivan Korotkov ...
8 years, 8 months ago (2012-04-16 16:45:57 UTC) #4
Joao da Silva
Looks good to me! Thanks for CCing.
8 years, 8 months ago (2012-04-16 17:29:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/10096012/3026
8 years, 8 months ago (2012-04-16 19:49:10 UTC) #6
commit-bot: I haz the power
Try job failure for 10096012-3026 (retry) on win_rel for step "update". It's a second try, ...
8 years, 8 months ago (2012-04-16 19:51:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/10096012/3026
8 years, 8 months ago (2012-04-16 20:17:54 UTC) #8
commit-bot: I haz the power
8 years, 8 months ago (2012-04-16 21:58:00 UTC) #9 
Change committed as 132469

Powered by Google App Engine
This is Rietveld 408576698