Improve parsing error handling in dmprof.

Improve parsing error handling in dmprof.


BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132541

[Dai Mikurube (NOT FULLTIME), 2012-04-16 11:30:40]

Hi Marc,

Could you take a look at it?


And, I wonder if you could tell me another good reviewer on Python scripts under
tools/ for next changes.

I may send many changes on/around this.  I hope that the code is reviewed by
many people, and reviews are load-balanced well.

[M-A Ruel, 2012-04-16 12:20:54]

lgtm with optional stuff.

http://codereview.chromium.org/10096009/diff/1/tools/deep_memory_profiler/dmprof
File tools/deep_memory_profiler/dmprof (right):

http://codereview.chromium.org/10096009/diff/1/tools/deep_memory_profiler/dmp...
tools/deep_memory_profiler/dmprof:314: (line_number, found) =
self.skip_lines_while(
since found is not used, you can either:
line_number = self.skip_lines_while(...)[0]
or
(lin_number, _) = self.skip_lines_while(...)

http://codereview.chromium.org/10096009/diff/1/tools/deep_memory_profiler/dmp...
tools/deep_memory_profiler/dmprof:412: if len(self.log_lines) <= 0:
len() < 0?
Just use:
if not self.log_lines:

http://codereview.chromium.org/10096009/diff/1/tools/deep_memory_profiler/dmp...
tools/deep_memory_profiler/dmprof:783: new_log.parse_log(buckets)
The functional part of me dislike the fact that a member function 'loads' the
object and prefers something like:
new_log = Log.parse_log(path, buckets)
but I don't mind.

[Dai Mikurube (NOT FULLTIME), 2012-04-17 03:26:32]

Thank you, Marc.

I'll be committing the change.

http://codereview.chromium.org/10096009/diff/1/tools/deep_memory_profiler/dmprof
File tools/deep_memory_profiler/dmprof (right):

http://codereview.chromium.org/10096009/diff/1/tools/deep_memory_profiler/dmp...
tools/deep_memory_profiler/dmprof:314: (line_number, found) =
self.skip_lines_while(
On 2012/04/16 12:20:55, Marc-Antoine Ruel wrote:
> since found is not used, you can either:
> line_number = self.skip_lines_while(...)[0]
> or
> (lin_number, _) = self.skip_lines_while(...)

Done.

http://codereview.chromium.org/10096009/diff/1/tools/deep_memory_profiler/dmp...
tools/deep_memory_profiler/dmprof:412: if len(self.log_lines) <= 0:
On 2012/04/16 12:20:55, Marc-Antoine Ruel wrote:
> len() < 0?
> Just use:
> if not self.log_lines:

Done.

http://codereview.chromium.org/10096009/diff/1/tools/deep_memory_profiler/dmp...
tools/deep_memory_profiler/dmprof:783: new_log.parse_log(buckets)
On 2012/04/16 12:20:55, Marc-Antoine Ruel wrote:
> The functional part of me dislike the fact that a member function 'loads' the
> object and prefers something like:
> new_log = Log.parse_log(path, buckets)
> but I don't mind.

I basically agree with you.  I'll do that in another change.

[commit-bot: I haz the power, 2012-04-17 03:26:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmikurube@chromium.org/10096009/4001

[commit-bot: I haz the power, 2012-04-17 04:44:26]

Change committed as 132541