Issue 10095029: Disable "always allowed" checkbox in chrome://plugins for disabled plug-ins.

Issue 10095029: Disable "always allowed" checkbox in chrome://plugins for disabled plug-ins. (Closed)

Created:
8 years, 8 months ago by Bernhard Bauer

Modified:
8 years, 8 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Disable "always allowed" checkbox in chrome://plugins for disabled plug-ins. BUG=124220 TEST=see bug for manual test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133423

Patch Set 2 : review #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -28 lines)			Patch
M	chrome/browser/resources/plugins.css	View	1	1 chunk	+3 lines, -12 lines	0 comments	Download
M	chrome/browser/resources/plugins.html	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/plugins.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/plugins_ui.cc	View		2 chunks	+4 lines, -13 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

lgtm https://chromiumcodereview.appspot.com/10095029/diff/1/chrome/browser/resources/plugins.css File chrome/browser/resources/plugins.css (right): https://chromiumcodereview.appspot.com/10095029/diff/1/chrome/browser/resources/plugins.css#newcode155 chrome/browser/resources/plugins.css:155: .disabled { can you change the name of ...

8 years, 8 months ago (2012-04-20 20:49:29 UTC) #2

Bernhard Bauer

https://chromiumcodereview.appspot.com/10095029/diff/1/chrome/browser/resources/plugins.css File chrome/browser/resources/plugins.css (right): https://chromiumcodereview.appspot.com/10095029/diff/1/chrome/browser/resources/plugins.css#newcode155 chrome/browser/resources/plugins.css:155: .disabled { On 2012/04/20 20:49:29, Evan Stade wrote: > ...

8 years, 8 months ago (2012-04-23 07:26:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/10095029/7001

8 years, 8 months ago (2012-04-23 07:26:20 UTC) #4

Change committed as 133423

Expand Messages | Collapse Messages