Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1827)

Unified Diff: chrome/common/extensions/api/experimental.socket.idl

Issue 10095020: Allow socket API to send binary data. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Jeremy's judgments. Antonits. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/experimental.socket.idl
diff --git a/chrome/common/extensions/api/experimental.socket.idl b/chrome/common/extensions/api/experimental.socket.idl
index 70a99b266257ad6c418282ed45b8485f2c57790c..b919b811005056ffac392e944d2d99d651a765c5 100644
--- a/chrome/common/extensions/api/experimental.socket.idl
+++ b/chrome/common/extensions/api/experimental.socket.idl
@@ -19,7 +19,8 @@
long? resultCode;
// The data read, if the event type is dataRead.
- DOMString? data;
+ // TODO(miket): [instanceOf=ArrayBuffer]object? data;
+ long[]? data;
// Whether this is the final event that this socket will send.
[nodoc] boolean isFinalEvent;
@@ -53,7 +54,8 @@
dictionary ReadInfo {
// The data received. Warning: will probably become a blob or other
// appropriate binary-friendly type.
- DOMString message;
+ // TODO(miket): [instanceOf=ArrayBuffer]object data;
+ long[] data;
};
callback ReadCallback = void (ReadInfo readInfo);
@@ -111,8 +113,9 @@
// write operation completes without blocking, the write operation blocked
// before completion (in which case onEvent() will eventually be called with
// a <code>writeComplete</code> event), or an error occurred.
+ // TODO(miket): [instanceOf=ArrayBuffer]object data;
static void write(long socketId,
- DOMString data,
+ long[] data,
WriteCallback callback);
};

Powered by Google App Engine
This is Rietveld 408576698