Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: chrome/browser/extensions/api/socket/tcp_socket_unittest.cc

Issue 10095020: Allow socket API to send binary data. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Jeremy's judgments. Antonits. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/socket/tcp_socket_unittest.cc
diff --git a/chrome/browser/extensions/api/socket/tcp_socket_unittest.cc b/chrome/browser/extensions/api/socket/tcp_socket_unittest.cc
index 8132e7899eda8a53e66110b332ff104861b1cf7a..1573fa57e4756216a2d107ef244dd4d330352e1e 100644
--- a/chrome/browser/extensions/api/socket/tcp_socket_unittest.cc
+++ b/chrome/browser/extensions/api/socket/tcp_socket_unittest.cc
@@ -8,6 +8,7 @@
#include "chrome/browser/extensions/api/api_resource_event_notifier.h"
#include "net/base/address_list.h"
#include "net/base/completion_callback.h"
+#include "net/base/io_buffer.h"
#include "net/base/net_errors.h"
#include "net/base/rand_callback.h"
#include "net/socket/tcp_client_socket.h"
@@ -56,7 +57,9 @@ TEST(SocketTest, TestTCPSocketRead) {
EXPECT_CALL(*tcp_client_socket, Read(_, _, _))
.Times(1);
- std::string message = socket->Read();
+ scoped_refptr<net::IOBufferWithSize> io_buffer(
+ new net::IOBufferWithSize(512));
+ socket->Read(io_buffer.get(), io_buffer->size());
}
TEST(SocketTest, TestTCPSocketWrite) {
@@ -70,7 +73,9 @@ TEST(SocketTest, TestTCPSocketWrite) {
EXPECT_CALL(*tcp_client_socket, Write(_, _, _))
.Times(1);
- socket->Write("foo");
+ scoped_refptr<net::IOBufferWithSize> io_buffer(
+ new net::IOBufferWithSize(256));
+ socket->Write(io_buffer.get(), io_buffer->size());
}
TEST(SocketTest, TestTCPSocketBlockedWrite) {
@@ -87,7 +92,10 @@ TEST(SocketTest, TestTCPSocketBlockedWrite) {
.WillOnce(testing::DoAll(SaveArg<2>(&callback),
Return(net::ERR_IO_PENDING)));
- ASSERT_EQ(net::ERR_IO_PENDING, socket->Write("foo"));
+ scoped_refptr<net::IOBufferWithSize> io_buffer(new net::IOBufferWithSize(
+ 1));
+ ASSERT_EQ(net::ERR_IO_PENDING, socket->Write(io_buffer.get(),
+ io_buffer->size()));
// Good. Original call came back unable to complete. Now pretend the socket
// finished, and confirm that we passed the error back.
« no previous file with comments | « chrome/browser/extensions/api/socket/socket_api.cc ('k') | chrome/browser/extensions/api/socket/udp_socket_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698