Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1185)

Unified Diff: chrome/browser/extensions/api/serial/serial_api.cc

Issue 10095020: Allow socket API to send binary data. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Jeremy's judgments. Antonits. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/serial/serial_api.cc
diff --git a/chrome/browser/extensions/api/serial/serial_api.cc b/chrome/browser/extensions/api/serial/serial_api.cc
index 26b523f43cc24b46eb16fec3b71a27479c5e8d43..c99c456ec85cf3595f5db590f2dee69e6465a6bd 100644
--- a/chrome/browser/extensions/api/serial/serial_api.cc
+++ b/chrome/browser/extensions/api/serial/serial_api.cc
@@ -13,7 +13,7 @@
namespace extensions {
const char kConnectionIdKey[] = "connectionId";
-const char kMessageKey[] = "message";
+const char kDataKey[] = "data";
const char kBytesReadKey[] = "bytesRead";
const char kBytesWrittenKey[] = "bytesWritten";
@@ -81,19 +81,19 @@ bool SerialReadFunction::Prepare() {
void SerialReadFunction::Work() {
int bytes_read = -1;
- std::string message;
+ std::string data;
SerialConnection* serial_connection =
controller()->GetSerialConnection(connection_id_);
if (serial_connection) {
unsigned char byte = '\0';
bytes_read = serial_connection->Read(&byte);
if (bytes_read == 1)
- message = byte;
+ data = byte;
}
DictionaryValue* result = new DictionaryValue();
result->SetInteger(kBytesReadKey, bytes_read);
- result->SetString(kMessageKey, message);
+ result->SetString(kDataKey, data);
result_.reset(result);
}
« no previous file with comments | « chrome/browser/extensions/api/api_resource_event_notifier.cc ('k') | chrome/browser/extensions/api/socket/socket.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698