Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Unified Diff: chrome/browser/extensions/api/socket/udp_socket_unittest.cc

Issue 10095020: Allow socket API to send binary data. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Patch Set 1 Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/socket/udp_socket_unittest.cc
diff --git a/chrome/browser/extensions/api/socket/udp_socket_unittest.cc b/chrome/browser/extensions/api/socket/udp_socket_unittest.cc
index 980e3e8cfd4e5633b68a7ff4ee6e6eb17cc9221f..b8c50a1d8e68ef99621b254d0cd257a9bf431074 100644
--- a/chrome/browser/extensions/api/socket/udp_socket_unittest.cc
+++ b/chrome/browser/extensions/api/socket/udp_socket_unittest.cc
@@ -7,6 +7,7 @@
#include "base/memory/scoped_ptr.h"
#include "chrome/browser/extensions/api/api_resource_event_notifier.h"
#include "net/base/completion_callback.h"
+#include "net/base/io_buffer.h"
#include "net/base/net_errors.h"
#include "net/base/rand_callback.h"
#include "net/udp/udp_client_socket.h"
@@ -56,7 +57,9 @@ TEST(SocketTest, TestUDPSocketRead) {
EXPECT_CALL(*udp_client_socket, Read(_, _, _))
.Times(1);
- std::string message = socket->Read();
+ scoped_refptr<net::IOBufferWithSize> io_buffer(
+ new net::IOBufferWithSize(512));
+ socket->Read(io_buffer.get(), io_buffer->size());
}
TEST(SocketTest, TestUDPSocketWrite) {
@@ -69,7 +72,9 @@ TEST(SocketTest, TestUDPSocketWrite) {
EXPECT_CALL(*udp_client_socket, Write(_, _, _))
.Times(1);
- socket->Write("foo");
+ scoped_refptr<net::IOBufferWithSize> io_buffer(
+ new net::IOBufferWithSize(512));
+ socket->Write(io_buffer.get(), io_buffer->size());
}
TEST(SocketTest, TestUDPSocketBlockedWrite) {
@@ -85,7 +90,9 @@ TEST(SocketTest, TestUDPSocketBlockedWrite) {
.WillOnce(testing::DoAll(SaveArg<2>(&callback),
Return(net::ERR_IO_PENDING)));
- ASSERT_EQ(net::ERR_IO_PENDING, socket->Write("foo"));
+ scoped_refptr<net::IOBufferWithSize> io_buffer(new net::IOBufferWithSize(1));
+ ASSERT_EQ(net::ERR_IO_PENDING, socket->Write(io_buffer.get(),
+ io_buffer->size()));
// Good. Original call came back unable to complete. Now pretend the socket
// finished, and confirm that we passed the error back.

Powered by Google App Engine
This is Rietveld 408576698