Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 10095011: Remove flaky unit test VideoCaptureTest::AllocateSameCameraTwice (Closed)

Created:
8 years, 8 months ago by perkj_chrome
Modified:
8 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Remove flaky unit test VideoCaptureTest::AllocateSameCameraTwice AllocateSameCameraTwice tested to open the same camera twice. However, this is can not happen in Chrome since the VideoCaptureManager ensure this. Further more, this have never worked on Mac and reasently have started to fail on Linux due to changes in the V4L2 driver behaviour. BUG= TEST= unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132552

Patch Set 1 #

Patch Set 2 : Readded DISABLED_MAYBE_AllocateBadSize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -35 lines) Patch
M media/video/capture/video_capture_device_unittest.cc View 1 2 chunks +0 lines, -35 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
perkj_chrome
Hi This fix the problem on newer Logitech cameras on Linux. However- it does not ...
8 years, 8 months ago (2012-04-16 13:15:35 UTC) #1
wjia(left Chromium)
lgtm
8 years, 8 months ago (2012-04-16 14:02:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/perkj@chromium.org/10095011/2001
8 years, 8 months ago (2012-04-17 07:26:44 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-17 08:50:09 UTC) #4
Change committed as 132552

Powered by Google App Engine
This is Rietveld 408576698