Issue 10095004: Add FlimflamDeviceClient

Issue 10095004: Add FlimflamDeviceClient (Closed)

Created:
8 years, 8 months ago by hashimoto

Modified:
8 years, 8 months ago

Reviewers:
stevenjb

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add FlimflamDeviceClient BUG=chromium-os:16557 TEST=chromeos_unittests --gtest_filter="FlimflamDeviceClientTest.*" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132538

Patch Set 3 : Fixed nits #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+817 lines, -0 lines)			Patch
M	chromeos/chromeos.gyp	View		3 chunks	+5 lines, -0 lines	0 comments	Download
M	chromeos/dbus/dbus_thread_manager.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	chromeos/dbus/dbus_thread_manager.cc	View		4 chunks	+10 lines, -0 lines	0 comments	Download
A	chromeos/dbus/flimflam_device_client.h	View		1 chunk	+130 lines, -0 lines	0 comments	Download
A	chromeos/dbus/flimflam_device_client.cc	View	1 2	1 chunk	+309 lines, -0 lines	0 comments	Download
A	chromeos/dbus/flimflam_device_client_unittest.cc	View	1 2	1 chunk	+273 lines, -0 lines	0 comments	Download
M	chromeos/dbus/mock_dbus_thread_manager.h	View		4 chunks	+6 lines, -0 lines	0 comments	Download
M	chromeos/dbus/mock_dbus_thread_manager.cc	View		3 chunks	+4 lines, -0 lines	0 comments	Download
A	chromeos/dbus/mock_flimflam_device_client.h	View		1 chunk	+61 lines, -0 lines	0 comments	Download
A	chromeos/dbus/mock_flimflam_device_client.cc	View		1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

stevenjb

lgtm with nits http://codereview.chromium.org/10095004/diff/1/chromeos/dbus/flimflam_device_client.cc File chromeos/dbus/flimflam_device_client.cc (right): http://codereview.chromium.org/10095004/diff/1/chromeos/dbus/flimflam_device_client.cc#newcode288 chromeos/dbus/flimflam_device_client.cc:288: DBUS_METHOD_CALL_SUCCESS)); nit: Since these all do ...

8 years, 8 months ago (2012-04-17 00:25:52 UTC) #2

hashimoto

http://codereview.chromium.org/10095004/diff/1/chromeos/dbus/flimflam_device_client.cc File chromeos/dbus/flimflam_device_client.cc (right): http://codereview.chromium.org/10095004/diff/1/chromeos/dbus/flimflam_device_client.cc#newcode288 chromeos/dbus/flimflam_device_client.cc:288: DBUS_METHOD_CALL_SUCCESS)); On 2012/04/17 00:25:52, stevenjb (chromium) wrote: > nit: ...

8 years, 8 months ago (2012-04-17 02:26:05 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10095004/4012

8 years, 8 months ago (2012-04-17 02:26:19 UTC) #4

Change committed as 132538

Expand Messages | Collapse Messages