chrome/browser/chromeos/media/media_player_browsertest.cc - Issue 10094012: Made File Manager respect the user-selected launch type (tab/pinned tab/window/fullscreen)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/media/media_player_browsertest.cc

Issue 10094012: Made File Manager respect the user-selected launch type (tab/pinned tab/window/fullscreen) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Moved changes requiring external OWNERs approval to another patch Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/media/media_player_browsertest.cc

diff --git a/chrome/browser/chromeos/media/media_player_browsertest.cc b/chrome/browser/chromeos/media/media_player_browsertest.cc

index 0b461db02acdd38ee5d5529c470964273bb4e122..729038773773078104bb00e1e203167ea983a5b0 100644

--- a/chrome/browser/chromeos/media/media_player_browsertest.cc

+++ b/chrome/browser/chromeos/media/media_player_browsertest.cc

@@ -48,7 +48,7 @@ IN_PROC_BROWSER_TEST_F(MediaPlayerBrowserTest, Popup) {

// Check that its not currently visible

ASSERT_FALSE(IsPlayerVisible());

- player->PopupMediaPlayer(NULL);

+ player->PopupMediaPlayer();

player->ForcePlayMediaURL(GetMusicTestURL());

ASSERT_TRUE(IsPlayerVisible());

« no previous file with comments | « chrome/browser/chromeos/media/media_player.cc ('k') | chrome/browser/chromeos/media/media_player_extension_api.cc » ('j') | no next file with comments »