chrome/browser/policy/cros_user_policy_cache.cc - Issue 10094010: Cleanup in policy code, removed some dead code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/cros_user_policy_cache.cc

Issue 10094010: Cleanup in policy code, removed some dead code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/policy/cros_user_policy_cache.cc

diff --git a/chrome/browser/policy/cros_user_policy_cache.cc b/chrome/browser/policy/cros_user_policy_cache.cc

index 19c0ba282bd7a0d426243a080c1e4349bafcf82a..0110244e513f6ef405c1f52941318009df2b5468 100644

--- a/chrome/browser/policy/cros_user_policy_cache.cc

+++ b/chrome/browser/policy/cros_user_policy_cache.cc

@@ -4,12 +4,10 @@

#include "chrome/browser/policy/cros_user_policy_cache.h"

-#include <string>

#include <vector>

#include "base/bind.h"

#include "base/callback.h"

-#include "base/file_path.h"

#include "base/file_util.h"

#include "chrome/browser/policy/proto/cloud_policy.pb.h"

#include "chrome/browser/policy/proto/device_management_backend.pb.h"

@@ -73,8 +71,10 @@ void CrosUserPolicyCache::StorePolicyOperation::Run() {

std::string serialized;

if (!policy_.SerializeToString(&serialized)) {

LOG(ERROR) << "Failed to serialize policy protobuf!";

- callback_.Run(false);

+ if (!callback_.is_null())

+ callback_.Run(false);

delete this;

+ return;

}

session_manager_client_->StoreUserPolicy(

serialized,

« no previous file with comments | « chrome/browser/policy/cros_user_policy_cache.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »