Issue 10093012: Update comments in socket_dispatcher.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10093012: Update comments in socket_dispatcher.h. (Closed)

Created:
8 years, 8 months ago by Sergey Ulanov

Modified:
8 years, 8 months ago

Reviewers:
perkj_chrome

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update comments in socket_dispatcher.h. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132594

Patch Set 2 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	content/renderer/p2p/socket_dispatcher.h	View	1	3 chunks	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

perkj_chrome

LGTM Please see my question. http://codereview.chromium.org/10093012/diff/1/content/renderer/p2p/socket_dispatcher.h File content/renderer/p2p/socket_dispatcher.h (right): http://codereview.chromium.org/10093012/diff/1/content/renderer/p2p/socket_dispatcher.h#newcode62 content/renderer/p2p/socket_dispatcher.h:62: // network configuration changes. ...

8 years, 8 months ago (2012-04-17 07:22:59 UTC) #2

Sergey Ulanov

8 years, 8 months ago (2012-04-17 17:34:37 UTC) #3

http://codereview.chromium.org/10093012/diff/1/content/renderer/p2p/socket_di...
File content/renderer/p2p/socket_dispatcher.h (right):

http://codereview.chromium.org/10093012/diff/1/content/renderer/p2p/socket_di...
content/renderer/p2p/socket_dispatcher.h:62: // network configuration changes.
Can be called on any thread.
On 2012/04/17 07:22:59, perkj wrote:
> On what thread is the callback called? On the same thread as called this
method?
> If I understood Mallinath correctly, that is why we create the network manager
> on libjingles worker thread.

Done.

Expand Messages | Collapse Messages

Issue 10093012: Update comments in socket_dispatcher.h. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages