Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: webkit/plugins/ppapi/plugin_delegate.h

Issue 10093011: Show a replacement plug-in for loading errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cleanup Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/plugins/ppapi/plugin_delegate.h
diff --git a/webkit/plugins/ppapi/plugin_delegate.h b/webkit/plugins/ppapi/plugin_delegate.h
index 1514a96348ca389bc55e4aea86309b73a42a2597..98c70114c5fda26f76403e2b04831528381591ee 100644
--- a/webkit/plugins/ppapi/plugin_delegate.h
+++ b/webkit/plugins/ppapi/plugin_delegate.h
@@ -55,10 +55,10 @@ class CommandBuffer;
}
namespace ppapi {
-class PPB_HostResolver_Shared;
-class PPB_X509Certificate_Fields;
struct DeviceRefData;
darin (slow to review) 2012/04/30 18:57:02 are you sure about this change? class is sorted b
Bernhard Bauer 2012/04/30 19:30:36 Up in lines 34–38 we sort by type name :)
struct HostPortPair;
+class PPB_HostResolver_Shared;
+class PPB_X509Certificate_Fields;
struct Preferences;
}
@@ -67,10 +67,11 @@ class PlatformCanvas;
}
namespace WebKit {
-class WebFileChooserCompletion;
-class WebGamepads;
struct WebCursorInfo;
+class WebFileChooserCompletion;
struct WebFileChooserParams;
+class WebGamepads;
+class WebPlugin;
}
namespace webkit_glue {
@@ -333,6 +334,11 @@ class PluginDelegate {
// sad plugin screen with. Returns NULL on failure.
virtual SkBitmap* GetSadPluginBitmap() = 0;
+ // Creates a replacement plug-in that is shown when the plug-in at |file_path|
+ // couldn't be loaded.
+ virtual WebKit::WebPlugin* CreatePluginReplacement(
+ const FilePath& file_path) = 0;
+
// The caller will own the pointer returned from this.
virtual PlatformImage2D* CreateImage2D(int width, int height) = 0;

Powered by Google App Engine
This is Rietveld 408576698