Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10093001: Remove duplicate tests of KeyEvent::has_pressed (Closed)

Created:
8 years, 8 months ago by Wez
Modified:
8 years, 8 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove duplicate tests of KeyEvent::has_pressed Cleans up some early-exit tests that duplicate checks in HostEventDispatcher, and which are verified in debug builds via DCHECKs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132381

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M remoting/host/event_executor_linux.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/host/event_executor_win.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Wez
8 years, 8 months ago (2012-04-14 23:31:09 UTC) #1
Sergey Ulanov
lgtm
8 years, 8 months ago (2012-04-15 17:30:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/10093001/1
8 years, 8 months ago (2012-04-15 17:54:22 UTC) #3
commit-bot: I haz the power
Try job failure for 10093001-1 (retry) (retry) on win_rel for step "browser_tests". It's a second ...
8 years, 8 months ago (2012-04-15 21:27:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/10093001/1
8 years, 8 months ago (2012-04-15 21:30:43 UTC) #5
commit-bot: I haz the power
Try job failure for 10093001-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 8 months ago (2012-04-15 23:46:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/10093001/1
8 years, 8 months ago (2012-04-15 23:53:02 UTC) #7
commit-bot: I haz the power
Try job failure for 10093001-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 8 months ago (2012-04-16 02:12:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/10093001/1
8 years, 8 months ago (2012-04-16 02:44:42 UTC) #9
commit-bot: I haz the power
Try job failure for 10093001-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 8 months ago (2012-04-16 05:12:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/10093001/1
8 years, 8 months ago (2012-04-16 05:24:48 UTC) #11
commit-bot: I haz the power
8 years, 8 months ago (2012-04-16 08:40:00 UTC) #12 
Change committed as 132381

Powered by Google App Engine
This is Rietveld 408576698