Mac: Prevent NTP mousewheel events from being suppressed on Lion.

chrome/browser/ui/webui/ntp/ntp_resource_cache.cc

Index: chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
diff --git a/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc b/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
index c5dadc2e31965856a8093cb71f8c33598049762d..5c7b380d138dafc61be6b098c87331da6d1b29a2 100644
--- a/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
+++ b/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
@@ -58,6 +58,10 @@
 #include "chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.h"
 #endif
 
+#if defined(OS_MACOSX)
+#include "chrome/browser/platform_util.h"
+#endif
+
 using base::Time;
 using content::BrowserThread;
 
@@ -195,13 +199,28 @@ NTPResourceCache::NTPResourceCache(Profile* profile) : profile_(profile) {
 
 NTPResourceCache::~NTPResourceCache() {}
 
+bool NTPResourceCache::NewTabCacheNeedsRefresh() {
+#if defined(OS_MACOSX)
+  // Invalidate if the current value is different from the cached value.
+  bool is_enabled = platform_util::IsSwipeTrackingFromScrollEventsEnabled();
+  if (is_enabled != is_swipe_tracking_from_scroll_events_enabled_) {
+    is_swipe_tracking_from_scroll_events_enabled_ = is_enabled;
+    return true;
+  }
+#endif
+  return false;
+}
+
 RefCountedMemory* NTPResourceCache::GetNewTabHTML(bool is_incognito) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   if (is_incognito) {
     if (!new_tab_incognito_html_.get())
       CreateNewTabIncognitoHTML();
   } else {
-    if (!new_tab_html_.get())
+    // Refresh the cached HTML if necessary.
+    // NOTE: NewTabCacheNeedsRefresh() must be called every time the new tab
+    // HTML is fetched, because it needs to initialized cached values.

[Evan Stade, 2012/04/18 21:16:35]

grammar

[Patrick Dubroy, 2012/04/19 10:53:50]

Done.

+    if (NewTabCacheNeedsRefresh() || !new_tab_html_.get())
       CreateNewTabHTML();
   }
   return is_incognito ? new_tab_incognito_html_.get() :
@@ -365,6 +384,12 @@ void NTPResourceCache::CreateNewTabHTML() {
   localized_strings.SetString("hideSessionMenuItemText",
       l10n_util::GetStringUTF16(IDS_POLICY_HIDE));
 
+  // On Mac OS X 10.7+, horizontal scrolling can be treated as a back or
+  // forward gesture. Pass through a flag that indicates whether or not that
+  // feature is enabled.
+  localized_strings.SetBoolean("isSwipeTrackingFromScrollEventsEnabled",
+                               is_swipe_tracking_from_scroll_events_enabled_);
+
 #if defined(OS_CHROMEOS)
   localized_strings.SetString("expandMenu",
       l10n_util::GetStringUTF16(IDS_NEW_TAB_CLOSE_MENU_EXPAND));