Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10091030: Allow full-page plug-ins for click-to-play. (Closed)

Created:
8 years, 8 months ago by Bernhard Bauer
Modified:
8 years, 8 months ago
Reviewers:
marja
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org, Peter Kasting
Visibility:
Public.

Description

Allow full-page plug-ins for click-to-play. BUG=62080 TEST=http://www/~bauerb/no_crawl/test/jumpers2.swf loads, http://www/~bauerb/no_crawl/test/install_flash.html and http://www/~bauerb/no_crawl/test/flash_iframe.html don't. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132597

Patch Set 1 #

Patch Set 2 : disallow plug-ins in popups #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/renderer/chrome_content_renderer_client.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bernhard Bauer
Please review.
8 years, 8 months ago (2012-04-17 12:39:13 UTC) #1
Bernhard Bauer
As discussed off-review, I'm also checking for a NULL opener now.
8 years, 8 months ago (2012-04-17 15:22:01 UTC) #2
marja
lgtm
8 years, 8 months ago (2012-04-17 15:29:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/10091030/2002
8 years, 8 months ago (2012-04-17 16:19:31 UTC) #4
commit-bot: I haz the power
8 years, 8 months ago (2012-04-17 17:42:28 UTC) #5 
Change committed as 132597

Powered by Google App Engine
This is Rietveld 408576698