Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 10091013: MIPS: Refactoring of code generation for declarations, in preparation for modules. (Closed)

Created:
8 years, 8 months ago by palfia
Modified:
8 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Refactoring of code generation for declarations, in preparation for modules. Port r11331 (bd7843a0) Original commit message: Refactoring of code generation for declarations, in preparation for modules. Do proper dispatch on declaration type instead of mingling together different code generation paths. Once we add more declaration forms, this is more scalable. In separate steps, I'd like to (1) clean up the logic for DeclareGlobal, and (2) try to reduce the special handling of the name function var if possible. BUG= TEST=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -60 lines) Patch
M src/mips/full-codegen-mips.cc View 6 chunks +141 lines, -60 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
palfia
Building and testing on mips also requires the following patches to be landed: http://codereview.chromium.org/10106007/ http://codereview.chromium.org/10103008/
8 years, 8 months ago (2012-04-16 22:06:53 UTC) #1
rossberg
lgtm
8 years, 8 months ago (2012-04-18 14:37:42 UTC) #2
rossberg
8 years, 8 months ago (2012-04-18 15:44:32 UTC) #3
Landed as r11372.

Powered by Google App Engine
This is Rietveld 408576698