Issue 10091011: Added function to get native path case on Windows and OSX.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10091011: Added function to get native path case on Windows and OSX. (Closed)

Created:
8 years, 8 months ago by M-A Ruel

Modified:
8 years, 8 months ago

Reviewers:
Nicolas Sylvain, nsylvain

CC:
chromium-reviews, pam+watch_chromium.org, csharp

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Added function to get native path case on Windows and OSX. Fixed all tests on Windows. Ignore \Device\Mup on Windows. Still saw some flakiness on tracing on Windows, to be addressed in a separate patch. R=nsylvain@chromium.org BUG=98834 TEST=Run all the isolate tests on Windows or OSX Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133475

Patch Set 1 #

Patch Set 2 : Fix child2.py #

Patch Set 3 : Rebase against 10080013 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+125 lines, -38 lines)			Patch
M	tools/isolate/data/trace_inputs/child2.py	View	1	1 chunk	+21 lines, -6 lines	0 comments	Download
M	tools/isolate/isolate.py	View	1 2	3 chunks	+13 lines, -3 lines	0 comments	Download
M	tools/isolate/isolate_smoke_test.py	View	1 2	2 chunks	+8 lines, -3 lines	0 comments	Download
M	tools/isolate/isolate_test.py	View	1 2	2 chunks	+5 lines, -0 lines	0 comments	Download
M	tools/isolate/trace_inputs.py	View		12 chunks	+73 lines, -24 lines	0 comments	Download
M	tools/isolate/trace_inputs_smoke_test.py	View		1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10091011/5001

8 years, 8 months ago (2012-04-23 16:21:20 UTC) #3

Change committed as 133475

Expand Messages | Collapse Messages