Convert flash to thunk

Convert the PPB_Flash interface to use the thunk system.

This was a bit tricky since some of the functions had no instance context, so I added global functions on the PpapiGlobals interface for them. It would be nice to add a PP_Instance argument and fix this in the future.

I did a new style of doing the thunking. The "function APIs" haven't really worked out since it's almost always easier to add the functions directly on the instance one. Since this is a larger and more separable chunk, I just added a getter on the instance API for the flash API and thunk through that. I'd like to convert the remaining ~3 function APIs to either call directly on the instance or use this method, but that's not addressed by this patch.

I moved the flash command line switch to plugin_switches so this could be hooked up properly. It allowed me to delete the delegate API for this.

I combined the flash fullscreen functions into the new Flash API which removed a bit of code.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133636

[yzshen1, 2012-04-18 17:57:22]

Only a few nits.

https://chromiumcodereview.appspot.com/10091003/diff/7001/content/ppapi_plugi...
File content/ppapi_plugin/ppapi_thread.cc (right):

https://chromiumcodereview.appspot.com/10091003/diff/7001/content/ppapi_plugi...
content/ppapi_plugin/ppapi_thread.cc:19: #include
"content/public/common/content_switches.h"
This may not be needed anymore.

https://chromiumcodereview.appspot.com/10091003/diff/7001/content/ppapi_plugi...
File content/ppapi_plugin/ppapi_thread.h (right):

https://chromiumcodereview.appspot.com/10091003/diff/7001/content/ppapi_plugi...
content/ppapi_plugin/ppapi_thread.h:37: explicit PpapiThread(const CommandLine&
command_line, bool is_broker);
'explicit' is not needed anymore.

https://chromiumcodereview.appspot.com/10091003/diff/7001/ppapi/ppapi_shared....
File ppapi/ppapi_shared.gypi (right):

https://chromiumcodereview.appspot.com/10091003/diff/7001/ppapi/ppapi_shared....
ppapi/ppapi_shared.gypi:188: 'thunk/ppb_flash_thunk.cc',
You may want to sort the list. (But I understand if you want to put api and
thunk together.)

https://chromiumcodereview.appspot.com/10091003/diff/7001/ppapi/proxy/ppb_fla...
File ppapi/proxy/ppb_flash_proxy.cc (right):

https://chromiumcodereview.appspot.com/10091003/diff/7001/ppapi/proxy/ppb_fla...
ppapi/proxy/ppb_flash_proxy.cc:97: ProxyAutoLock lock;
I think this is not needed now, right?

https://chromiumcodereview.appspot.com/10091003/diff/7001/ppapi/thunk/ppb_fla...
File ppapi/thunk/ppb_flash_thunk.cc (right):

https://chromiumcodereview.appspot.com/10091003/diff/7001/ppapi/thunk/ppb_fla...
ppapi/thunk/ppb_flash_thunk.cc:11: #include "ppapi/thunk/enter.h"
sort, please.

https://chromiumcodereview.appspot.com/10091003/diff/7001/ppapi/thunk/ppb_fla...
ppapi/thunk/ppb_flash_thunk.cc:13: #include "ppapi/thunk/ppb_flash_api.h"
and here.

https://chromiumcodereview.appspot.com/10091003/diff/7001/ppapi/thunk/ppb_fla...
ppapi/thunk/ppb_flash_thunk.cc:84: return PP_FALSE;
Wrong return type.

https://chromiumcodereview.appspot.com/10091003/diff/7001/ppapi/thunk/ppb_fla...
ppapi/thunk/ppb_flash_thunk.cc:140: return PP_FALSE;
Wrong return type.

https://chromiumcodereview.appspot.com/10091003/diff/7001/webkit/plugins/ppap...
File webkit/plugins/ppapi/ppb_flash_impl.cc (right):

https://chromiumcodereview.appspot.com/10091003/diff/7001/webkit/plugins/ppap...
webkit/plugins/ppapi/ppb_flash_impl.cc:38: using ppapi::thunk::EnterResource;
This is not needed anymore.

https://chromiumcodereview.appspot.com/10091003/diff/7001/webkit/plugins/ppap...
File webkit/plugins/ppapi/ppb_flash_impl.h (right):

https://chromiumcodereview.appspot.com/10091003/diff/7001/webkit/plugins/ppap...
webkit/plugins/ppapi/ppb_flash_impl.h:20: PPB_Flash_Impl(PluginInstance*
instance);
explicit, please.

[brettw, 2012-04-19 18:30:54]

New patch up PTAL

[yzshen1, 2012-04-19 19:03:23]

lgtm