Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2664)

Unified Diff: chrome/common/extensions/extension.h

Issue 10086019: Use the non-localized "canonical name" of an extension to write to its sync (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: rename, test Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_sync_data.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension.h
diff --git a/chrome/common/extensions/extension.h b/chrome/common/extensions/extension.h
index 9a5d575ec818724084b87f29f534b83f3ba8a07e..23c0293187f2387aae12753817e27222b92b6e37 100644
--- a/chrome/common/extensions/extension.h
+++ b/chrome/common/extensions/extension.h
@@ -560,6 +560,7 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
const Version* version() const { return version_.get(); }
const std::string VersionString() const;
const std::string& name() const { return name_; }
+ const std::string& non_localized_name() const { return non_localized_name_; }
const std::string public_key() const { return public_key_; }
const std::string& description() const { return description_; }
int manifest_version() const { return manifest_version_; }
@@ -869,6 +870,10 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
// NOTE: Name is UTF-8 and may contain non-ascii characters.
std::string name_;
+ // A non-localized version of the extension's name. This is useful for
+ // debug output.
+ std::string non_localized_name_;
+
// The version of this extension's manifest. We increase the manifest
// version when making breaking changes to the extension system.
// Version 1 was the first manifest version (implied by a lack of a
« no previous file with comments | « chrome/browser/extensions/extension_sync_data.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698