Use the non-localized "canonical name" of an extension to write to its sync

chrome/common/extensions/extension_manifests_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension.h"
 
 #if defined(TOOLKIT_GTK)
 #include <gtk/gtk.h>
 #endif
 
@@ skipping 236 matching lines @@
   scoped_refptr<Extension> extension(LoadAndExpectSuccess(
       "init_valid_minimal.json"));
 
   FilePath path;
   PathService::Get(chrome::DIR_TEST_DATA, &path);
   path = path.AppendASCII("extensions");
 
   EXPECT_TRUE(Extension::IdIsValid(extension->id()));
   EXPECT_EQ("1.0.0.0", extension->VersionString());
   EXPECT_EQ("my extension", extension->name());
+  EXPECT_EQ("my extension", extension->non_localized_name());
   EXPECT_EQ(extension->id(), extension->url().host());
   EXPECT_EQ(extension->path(), path);
   EXPECT_EQ(path, extension->path());
 
   // Test permissions scheme.
   // We allow unknown API permissions, so this will be valid until we better
   // distinguish between API and host permissions.
   extension = LoadAndExpectSuccess("init_valid_permissions.json");
 
   // Test with an options page.
@@ skipping 110 matching lines @@
 #else
   std::string locale = l10n_util::GetApplicationLocale("");
   base::i18n::SetICUDefaultLocale("he");
 #endif
 
   // No strong RTL characters in name.
   scoped_refptr<Extension> extension(LoadAndExpectSuccess(
       "init_valid_name_no_rtl.json"));
 
   string16 localized_name(ASCIIToUTF16("Dictionary (by Google)"));
+  EXPECT_EQ(localized_name, UTF8ToUTF16(extension->non_localized_name()));
+
   base::i18n::AdjustStringForLocaleDirection(&localized_name);
   EXPECT_EQ(localized_name, UTF8ToUTF16(extension->name()));
 
   // Strong RTL characters in name.
   extension = LoadAndExpectSuccess("init_valid_name_strong_rtl.json");
 
   localized_name = WideToUTF16(L"Dictionary (\x05D1\x05D2"L" Google)");
+  EXPECT_EQ(localized_name, UTF8ToUTF16(extension->non_localized_name()));
+
   base::i18n::AdjustStringForLocaleDirection(&localized_name);
   EXPECT_EQ(localized_name, UTF8ToUTF16(extension->name()));
 
   // Reset locale.
 #if defined(TOOLKIT_GTK)
   gtk_widget_set_default_direction(gtk_dir);
 #else
   base::i18n::SetICUDefaultLocale(locale);
 #endif
 }
@@ skipping 871 matching lines @@
   // Extension with manifest version 2 *can* use storage API.
   {
     DictionaryValue manifest_with_version;
     manifest_with_version.SetInteger(keys::kManifestVersion, 2);
     manifest_with_version.MergeDictionary(&base_manifest);
 
     Manifest manifest(&manifest_with_version, "test");
     LoadAndExpectSuccess(manifest);
   }
 }