chrome/browser/ui/views/toolbar_view.cc - Issue 10084030: views: Fix some DCHECKs to use (expected, actual) order.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar_view.cc

Issue 10084030: views: Fix some DCHECKs to use (expected, actual) order. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/toolbar_view.cc

diff --git a/chrome/browser/ui/views/toolbar_view.cc b/chrome/browser/ui/views/toolbar_view.cc

index c0902e119d27ccff5083e52444bbc83844d67603..5d3c27af31587b4dca2271012209cb66ffc613ef 100644

--- a/chrome/browser/ui/views/toolbar_view.cc

+++ b/chrome/browser/ui/views/toolbar_view.cc

@@ -353,7 +353,7 @@ bool ToolbarView::GetAcceleratorInfo(int id, ui::Accelerator* accel) {

void ToolbarView::OnMenuButtonClicked(views::View* source,

const gfx::Point& point) {

- DCHECK_EQ(VIEW_ID_APP_MENU, source->id());

+ DCHECK_EQ(source->id(), VIEW_ID_APP_MENU);

Peter Kasting 2012/04/16 18:16:25 The old code here was correct.

wrench_menu_.reset(new WrenchMenu(browser_));

WrenchMenuModel model(this, browser_);

« no previous file with comments | « chrome/browser/ui/views/task_manager_view.cc ('k') | no next file » | no next file with comments »