Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 10084022: Fix crash when changing sources after createMediaSourceElement(). (Closed)

Created:
8 years, 8 months ago by Raymond Toy (Google)
Modified:
8 years, 8 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Fix crash when changing sources after createMediaSourceElement(). BUG=112749 TEST=See 112749 or 121262 for the test case that works now. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133625

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/media/render_audiosourceprovider.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Chris Rogers
LGTM
8 years, 8 months ago (2012-04-23 21:22:09 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 8 months ago (2012-04-23 21:23:13 UTC) #2
Chris Rogers
Hi Andrew, would you mind giving a rubber-stamp OWNERS approval here? thanks!
8 years, 8 months ago (2012-04-23 22:00:28 UTC) #3
scherkus (not reviewing)
lgtm
8 years, 8 months ago (2012-04-24 01:08:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@google.com/10084022/1
8 years, 8 months ago (2012-04-24 01:12:51 UTC) #5
commit-bot: I haz the power
8 years, 8 months ago (2012-04-24 03:41:23 UTC) #6
Change committed as 133625

Powered by Google App Engine
This is Rietveld 408576698